do not save token Id, if value is null#149
Merged
jankapunkt merged 3 commits intofix/connection-eventsfrom Feb 13, 2024
Merged
Conversation
Collaborator
Author
|
@jankapunkt Can you check why lint fails? Local |
jankapunkt
reviewed
Feb 13, 2024
| console.error.apply(console, arguments); | ||
| } | ||
| : function () {}; | ||
| } |
Member
There was a problem hiding this comment.
I think the linter has some weird understanding of indentation on nested ternary operators. Maybe this one might work:
if (typeof Meteor !== 'undefined') {
return Meteor._debug;
}
return typeof console !== 'undefined' && console.error
? function () { console.error.apply(console, arguments); }
: function () {};
jankapunkt
reviewed
Feb 13, 2024
Collaborator
Author
|
Ok looks like lint is working now. Could figure out why it did not throw any errors on my box though... |
jankapunkt
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not save token Id on logging in, if no value is provided
Linked issue(s)
#148
Involved parts of the project
User.jsReproduction
cf. the PR; however, I could observe improved resuming of a suspended iOS app, successfully restoring the session user.