Conversation
dra27
left a comment
There was a problem hiding this comment.
There're various idioms in msvs-promote-path where I simply can't remember whether the idiom is me being silly, Cygwin being silly or Windows-over-Cygwin being weird! It makes me very cautious to adjust without a clear bug being fixed, though.
I don't particularly want to update msvs-promote-path without an actual bug to fix, so I'll skip b70ce0f, though I'll note that I have no idea why I used -a and && [ … ] in the same if 🤦♂️
Likewise, the changes in 22b3762 may be correct, but I don't relish having to fire up the test VM with VS 2002, VS 2003, VS 2005, .., 2015 to be sure it's behaving correctly on all those code paths! The whitespace fix is good, though 😊
07be037, 85fd26c, 33f323b and da5e8f9 are all good to go, though, thanks!
Would you remind rebasing without b70ce0f and with 22b3762 reduced to a whitespace-only fix, please?
b70ce0f to
3d0ea1f
Compare
|
Done, rebased against master. For reference, the old branch is archived in https://github.com/MisterDA/msvs-tools/tree/path-blowup-shellcheck-bak. |
|
My comment about b70ce0f is daft, if you want to push that back to the branch, and I'll merge |
eaa72d4 to
084a2d6
Compare
|
Thank you! |
I ran Shellcheck on the scripts and fixed warnings on top of #6 (I’ll rebase if you push more commits).
There are some warnings remaining. Those about quoting seem false-positives, you may want to look at the others.
Shellcheck doesn’t parse the construct
eval array+=(element). Temporary applying this patch is needed to make it parse the file: