Fix path blow-up with environment compiler#6
Merged
dra27 merged 7 commits intometastack:masterfrom Jun 26, 2020
Merged
Conversation
Ensure that PATH overrides never result in picking up a different command (in particular, one in another Cygwin installation)
cygpath may put trailing slashes back into a path which causing the suffix removal of the original PATH from MSVS_PATH to fail.
SetEnv-style scripts use %ORIGINALPATH% to allow them to be called repeatedly - erase this variable to prevent the Cygwin PATH being erased.
Some developer tools in recent Visual Studio add components to the end of PATH instead of the beginning.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testsuite slightly improved.
Deals with the path blow-up in ocaml/opam#4242 (opam's script invokes msvs-detect and then so does flexdll)