Merged
Conversation
Contributor
|
@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lucylq
added a commit
to lucylq/tokenizers
that referenced
this pull request
Feb 19, 2025
Summary: Pull Request resolved: meta-pytorch#21 Test Plan: ## OSS Build ``` cmake . -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out cmake --build cmake-out -j9 --target install ``` Test ``` (executorch) [lfq@devvm20128.prn0 /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest Test project /data/users/lfq/tokenizers/cmake-out Start 1: test_base64 1/5 Test meta-pytorch#1: test_base64 ...................... Passed 0.00 sec Start 2: test_llama2c_tokenizer 2/5 Test meta-pytorch#2: test_llama2c_tokenizer ........... Passed 0.00 sec Start 3: test_pre_tokenizer 3/5 Test meta-pytorch#3: test_pre_tokenizer ............... Passed 0.73 sec Start 4: test_sentencepiece 4/5 Test meta-pytorch#4: test_sentencepiece ............... Passed 0.04 sec Start 5: test_tiktoken 5/5 Test meta-pytorch#5: test_tiktoken .................... Passed 3.32 sec 100% tests passed, 0 tests failed out of 5 Total Test time (real) = 4.10 sec ``` ## Internal ``` buck2 test fbsource//xplat/pytorch/tokenizers/test: buck2 test fbcode//pytorch/tokenizers/test: ``` Differential Revision: D69860352 Pulled By: lucylq
cba637e to
bf530db
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69860352 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Feb 19, 2025
Summary: Pull Request resolved: meta-pytorch/tokenizers#21 Test Plan: ## OSS Build ``` cmake . -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out cmake --build cmake-out -j9 --target install ``` Test ``` (executorch) [lfq@devvm20128.prn0 /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest Test project /data/users/lfq/tokenizers/cmake-out Start 1: test_base64 1/5 Test meta-pytorch/tokenizers#1: test_base64 ...................... Passed 0.00 sec Start 2: test_llama2c_tokenizer 2/5 Test meta-pytorch/tokenizers#2: test_llama2c_tokenizer ........... Passed 0.00 sec Start 3: test_pre_tokenizer 3/5 Test meta-pytorch/tokenizers#3: test_pre_tokenizer ............... Passed 0.73 sec Start 4: test_sentencepiece 4/5 Test meta-pytorch/tokenizers#4: test_sentencepiece ............... Passed 0.04 sec Start 5: test_tiktoken 5/5 Test meta-pytorch/tokenizers#5: test_tiktoken .................... Passed 3.32 sec 100% tests passed, 0 tests failed out of 5 Total Test time (real) = 4.10 sec ``` ## Internal ``` buck2 test fbsource//xplat/pytorch/tokenizers/test: buck2 test fbcode//pytorch/tokenizers/test: ``` Differential Revision: D69860352 Pulled By: lucylq
Summary: X-link: pytorch/executorch#8586 Test Plan: ## OSS Build ``` cmake . -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out cmake --build cmake-out -j9 --target install ``` Test ``` (executorch) [lfq@devvm20128.prn0 /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest Test project /data/users/lfq/tokenizers/cmake-out Start 1: test_base64 1/5 Test meta-pytorch#1: test_base64 ...................... Passed 0.00 sec Start 2: test_llama2c_tokenizer 2/5 Test meta-pytorch#2: test_llama2c_tokenizer ........... Passed 0.00 sec Start 3: test_pre_tokenizer 3/5 Test meta-pytorch#3: test_pre_tokenizer ............... Passed 0.73 sec Start 4: test_sentencepiece 4/5 Test meta-pytorch#4: test_sentencepiece ............... Passed 0.04 sec Start 5: test_tiktoken 5/5 Test meta-pytorch#5: test_tiktoken .................... Passed 3.32 sec 100% tests passed, 0 tests failed out of 5 Total Test time (real) = 4.10 sec ``` ## Internal ``` buck2 test fbsource//xplat/pytorch/tokenizers/test: buck2 test fbcode//pytorch/tokenizers/test: ``` Reviewed By: larryliu0820 Differential Revision: D69860352 Pulled By: lucylq
bf530db to
9b354ae
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69860352 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Feb 19, 2025
Summary: X-link: meta-pytorch/tokenizers#21 Test Plan: ## OSS Build ``` cmake . -DCMAKE_INSTALL_PREFIX=cmake-out -DTOKENIZERS_BUILD_TEST=ON -Bcmake-out cmake --build cmake-out -j9 --target install ``` Test ``` (executorch) [lfq@devvm20128.prn0 /data/users/lfq/tokenizers/cmake-out (lfq.tokenizer-test)]$ ctest Test project /data/users/lfq/tokenizers/cmake-out Start 1: test_base64 1/5 Test meta-pytorch/tokenizers#1: test_base64 ...................... Passed 0.00 sec Start 2: test_llama2c_tokenizer 2/5 Test meta-pytorch/tokenizers#2: test_llama2c_tokenizer ........... Passed 0.00 sec Start 3: test_pre_tokenizer 3/5 Test meta-pytorch/tokenizers#3: test_pre_tokenizer ............... Passed 0.73 sec Start 4: test_sentencepiece 4/5 Test meta-pytorch/tokenizers#4: test_sentencepiece ............... Passed 0.04 sec Start 5: test_tiktoken 5/5 Test meta-pytorch/tokenizers#5: test_tiktoken .................... Passed 3.32 sec 100% tests passed, 0 tests failed out of 5 Total Test time (real) = 4.10 sec ``` ## Internal ``` buck2 test fbsource//xplat/pytorch/tokenizers/test: buck2 test fbcode//pytorch/tokenizers/test: ``` Reviewed By: larryliu0820 Differential Revision: D69860352 Pulled By: lucylq
larryliu0820
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
buck changes
Test Plan
Build
Test