This repository was archived by the owner on Aug 7, 2024. It is now read-only.
fix nits from deletion of Float8DynamicLinear#308
Closed
vkuzo wants to merge 1 commit intogh/vkuzo/23/basefrom
Closed
fix nits from deletion of Float8DynamicLinear#308vkuzo wants to merge 1 commit intogh/vkuzo/23/basefrom
vkuzo wants to merge 1 commit intogh/vkuzo/23/basefrom
Conversation
Summary: Addressing a couple of nits that slipped in #304 * more defaults to dynamic * undo repr change * fix comment Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
drisspg
approved these changes
Jul 8, 2024
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request has been merged in 13f2c26. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Addressing a couple of nits that slipped in
#304
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59521233