[DataLoader2] Skip wrapping if serialization wrapper attached & deepcopy DataPipe in load_state_dict#833
Closed
ejguan wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Conversation
…opy DataPipe in load_state_dict
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Oct 17, 2022
Contributor
NivekT
left a comment
There was a problem hiding this comment.
LGTM! Question: do we expect any case where the datapipe being passed in already has a wrapper?
Contributor
Author
It's more like a future proof. (Technically, if users manually |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Oct 21, 2022
…n load_state_dict (meta-pytorch#833) Summary: Per title - We don't need to attach serialization wrapper if the last DataPipe has been `_DataPipeSerializationWrapper` - When we `load_state_dict`, we still need a copy of `self.datapipe` as it has been done in `__init__` function. We should either do deepcoy to `self._datapipe_before_reading_service_adapt` or skip deepcopy to `self._datapipe_before_reading_service_adapt` at those two places. Pull Request resolved: meta-pytorch#833 Reviewed By: NivekT Differential Revision: D40399573 Pulled By: ejguan fbshipit-source-id: 16fc80bd005a4b8671d48780c7aea8f164bccba8
ejguan
added a commit
that referenced
this pull request
Oct 21, 2022
…n load_state_dict (#833) Summary: Per title - We don't need to attach serialization wrapper if the last DataPipe has been `_DataPipeSerializationWrapper` - When we `load_state_dict`, we still need a copy of `self.datapipe` as it has been done in `__init__` function. We should either do deepcoy to `self._datapipe_before_reading_service_adapt` or skip deepcopy to `self._datapipe_before_reading_service_adapt` at those two places. Pull Request resolved: #833 Reviewed By: NivekT Differential Revision: D40399573 Pulled By: ejguan fbshipit-source-id: 16fc80bd005a4b8671d48780c7aea8f164bccba8
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Oct 23, 2022
…n load_state_dict (meta-pytorch#833) Summary: Per title - We don't need to attach serialization wrapper if the last DataPipe has been `_DataPipeSerializationWrapper` - When we `load_state_dict`, we still need a copy of `self.datapipe` as it has been done in `__init__` function. We should either do deepcoy to `self._datapipe_before_reading_service_adapt` or skip deepcopy to `self._datapipe_before_reading_service_adapt` at those two places. Pull Request resolved: meta-pytorch#833 Reviewed By: NivekT Differential Revision: D40399573 Pulled By: ejguan fbshipit-source-id: 16fc80bd005a4b8671d48780c7aea8f164bccba8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per title
_DataPipeSerializationWrapperload_state_dict, we still need a copy ofself.datapipeas it has been done in__init__function. We should align the behavior ofload_state_dictand__init__self._datapipe_before_reading_service_adaptself._datapipe_before_reading_service_adaptat those two places.