Refactor to use traverse_dps instead of traverse#793
Closed
NivekT wants to merge 2 commits intogh/NivekT/94/basefrom
Closed
Refactor to use traverse_dps instead of traverse#793NivekT wants to merge 2 commits intogh/NivekT/94/basefrom
traverse_dps instead of traverse#793NivekT wants to merge 2 commits intogh/NivekT/94/basefrom
Conversation
[ghstack-poisoned]
traverse_dps instead of traverse
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
approved these changes
Sep 27, 2022
Contributor
ejguan
left a comment
There was a problem hiding this comment.
LGTM. Let's wait until the nightly is updated. And, we can't land this PR right now since the PyTorch core Diff has not been merged yet.
Contributor
Author
|
There is a circular import issue. Let me have a look tomorrow. |
This should be merged only after pytorch/pytorch#85667 has been merged into nightly and internal. Differential Revision: [D39860692](https://our.internmc.facebook.com/intern/diff/D39860692) [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
traverse_dpsinstead oftraverse#793This should be merged only after pytorch/pytorch#85667 has been merged into nightly and internal.
Differential Revision: D39860692