Conversation
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Jul 26, 2022
Contributor
NivekT
left a comment
There was a problem hiding this comment.
LGTM! Just some questions:
S3is not compatible with Windows, correct?- We are building the same way regardless if it is MacOS x86_64 or arm64?
Comment on lines
+81
to
+85
| - name: Setup Python ${{ matrix.python-version }} | ||
| if: ${{ startsWith( matrix.os, 'windows' ) }} | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} |
Contributor
There was a problem hiding this comment.
QQ: Was windows already setting up Python before? Was this not needed until now?
Contributor
Author
There was a problem hiding this comment.
ejguan
commented
Jul 26, 2022
| python-version: 3.7 | ||
| steps: | ||
| - name: Setup Python ${{ matrix.python-version }} | ||
| if: ${{ ! startsWith( matrix.os, 'ubuntu' ) }} |
Contributor
Author
There was a problem hiding this comment.
Previously, we excluded ubuntu from this step because ubuntu used docker. Now, since macos would use conda to install python, windows becomes the only platform that would use this step.
cc: @NivekT
Contributor
Author
Actually, it is compatible. And, we do compile AWSSDK for PyPI wheels. However, for conda packages, I haven't figured out how to integrate AWSSDK with torchdata. I decide not to invest more time on it unless there are more users' request
Yea, the same workflow. |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jul 27, 2022
Summary: Fixes meta-pytorch#676 - Update the workflow to compile AWSSDK and integrated on arm64 macos - Use conda to install python since this [action](https://github.com/actions/setup-python) doesn't work with arm64b macos - Exclude python 3.7 from arm64 macos due to the pre-compiled python binary is not available either on conda or python official website - Use `bash -l {0}` to make sure `conda` is available across steps - Please check the manually triggered [workflow](https://github.com/pytorch/data/runs/7528349378?check_suite_focus=true) - Wheels: https://github.com/pytorch/data/runs/7528349378?check_suite_focus=true#step:4:1 - Conda packages: https://github.com/pytorch/data/runs/7528462809?check_suite_focus=true#step:5:1 Pull Request resolved: meta-pytorch#692 Reviewed By: NivekT Differential Revision: D38172672 Pulled By: ejguan fbshipit-source-id: d7ae1fd523fc140d5bc7b9d526b9a421cfd2eff6
ejguan
added a commit
that referenced
this pull request
Jul 27, 2022
Summary: Fixes #676 - Update the workflow to compile AWSSDK and integrated on arm64 macos - Use conda to install python since this [action](https://github.com/actions/setup-python) doesn't work with arm64b macos - Exclude python 3.7 from arm64 macos due to the pre-compiled python binary is not available either on conda or python official website - Use `bash -l {0}` to make sure `conda` is available across steps - Please check the manually triggered [workflow](https://github.com/pytorch/data/runs/7528349378?check_suite_focus=true) - Wheels: https://github.com/pytorch/data/runs/7528349378?check_suite_focus=true#step:4:1 - Conda packages: https://github.com/pytorch/data/runs/7528462809?check_suite_focus=true#step:5:1 Pull Request resolved: #692 Reviewed By: NivekT Differential Revision: D38172672 Pulled By: ejguan fbshipit-source-id: d7ae1fd523fc140d5bc7b9d526b9a421cfd2eff6
adamjstewart
reviewed
Aug 5, 2022
| - macos-latest | ||
| - ubuntu-latest | ||
| - windows-latest | ||
| - macos-m1-12 |
There was a problem hiding this comment.
Is this an internal Meta self-hosted runner or does GitHub Actions finally have public M1 runners?
Contributor
Author
There was a problem hiding this comment.
Our self-hosted runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #676
Changes
bash -l {0}to make surecondais available across steps