DataFrameMakerIterDataPipe now allows dtype_generator to be passed.#537
Closed
VitalyFedyunin wants to merge 5 commits intogh/VitalyFedyunin/5/basefrom
Closed
DataFrameMakerIterDataPipe now allows dtype_generator to be passed.#537VitalyFedyunin wants to merge 5 commits intogh/VitalyFedyunin/5/basefrom
VitalyFedyunin wants to merge 5 commits intogh/VitalyFedyunin/5/basefrom
Conversation
This is required for the usecases when dtype itself is not serializable and can't be part of the graph. [ghstack-poisoned]
…e passed." This is required for the usecases when dtype itself is not serializable and can't be part of the graph. [ghstack-poisoned]
NivekT
approved these changes
Jun 22, 2022
Contributor
NivekT
left a comment
There was a problem hiding this comment.
LGTM! Probably add some basic test if possible.
| dtype=None, | ||
| dataframe_size: int = 1000, # or Page Size | ||
| dtype=None, # Optional[torcharrow.dtypes.DType] | ||
| dtype_generator = None, |
Contributor
There was a problem hiding this comment.
Add the new argument to the docstring:
dtype_generator: function with no input argument that generates a torcharrow.dtypes.DType, which overrides dtype if both are given. This is useful for when the desired dtype is not serializable.
…e passed." This is required for the usecases when dtype itself is not serializable and can't be part of the graph. [ghstack-poisoned]
…e passed." This is required for the usecases when dtype itself is not serializable and can't be part of the graph. [ghstack-poisoned]
Contributor
Author
|
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…e passed." This is required for the usecases when dtype itself is not serializable and can't be part of the graph. Differential Revision: [D37522091](https://our.internmc.facebook.com/intern/diff/D37522091) [ghstack-poisoned]
Contributor
Author
|
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is required for the usecases when dtype itself is not serializable and can't be part of the graph.
Differential Revision: D37522091