Enable miniepoch for MultiProcessingReadingService#1147
Closed
ejguan wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Enable miniepoch for MultiProcessingReadingService#1147ejguan wants to merge 1 commit intometa-pytorch:mainfrom
ejguan wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45289736 |
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45289736 |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 2, 2023
Summary: Add `pause`, `resume`, `limit` API to `MultiProcessingReadingService` to support miniepoch API. - Adding a function as the input to make sure it working with internal ReadingService to control miniepoch within the worker/dispatching process Pull Request resolved: meta-pytorch#1147 Differential Revision: D45289736 Pulled By: ejguan fbshipit-source-id: 66a130e17eb32d5aa4a76c8c98f84ca0948a3043
f191614 to
4b65c80
Compare
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 2, 2023
Summary: Add `pause`, `resume`, `limit` API to `MultiProcessingReadingService` to support miniepoch API. - Adding a function as the input to make sure it working with internal ReadingService to control miniepoch within the worker/dispatching process All tests should be passing in `test/dataloader2/test_mrps.py` Pull Request resolved: meta-pytorch#1147 Differential Revision: D45289736 Pulled By: ejguan fbshipit-source-id: aaa6e5c93673bfce151f72bd1b00899cce423166
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45289736 |
NivekT
reviewed
May 2, 2023
Contributor
NivekT
left a comment
There was a problem hiding this comment.
With this PR, is pause/resume full functional with dispatching process? Or is something still missing?
NivekT
approved these changes
May 2, 2023
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Add `pause`, `resume`, `limit` API to `MultiProcessingReadingService` to support miniepoch API. - Adding a function as the input to make sure it working with internal ReadingService to control miniepoch within the worker/dispatching process All tests should be passing in `test/dataloader2/test_mrps.py` Pull Request resolved: meta-pytorch#1147 Reviewed By: NivekT Differential Revision: D45289736 Pulled By: ejguan fbshipit-source-id: d8444c310b697b6c8a5e2f8ad3304aabfce5ae34
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45289736 |
Contributor
Contributor
|
This pull request has been reverted by bda2c18. |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 23, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Differential Revision: D45666912 fbshipit-source-id: 05743228c4102c76825030bcbf502a5154da6f52
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 23, 2023
…pytorch#1170) Summary: Pull Request resolved: meta-pytorch#1170 A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Differential Revision: D45666912 fbshipit-source-id: 48176f10354494754f47a96a1ca166ed45e7e247
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 23, 2023
…pytorch#1170) Summary: Pull Request resolved: meta-pytorch#1170 A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Differential Revision: D45666912 fbshipit-source-id: a2e064371a510463cc13253419aa7d95233bf41e
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 23, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: meta-pytorch#1170 Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: 1e88dde3af0f406c062ca523e7b96a3c79a74b6d
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 26, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: meta-pytorch#1170 Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: 1e88dde3af0f406c062ca523e7b96a3c79a74b6d
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 26, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: meta-pytorch#1170 Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: ddff582f35a25528a2b8a1751ea0d0359f866ed0
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 26, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: meta-pytorch#1170 Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: f533892a1ffcdc103988a724bea8ce20572465b6
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 26, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: meta-pytorch#1170 Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: 40ec4eef0fdf1de05d3a545e08c11f155446ae2d
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 26, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: meta-pytorch#1170 Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: ffafcbb0b78add9c863d2faaec7248332ef36f68
ejguan
added a commit
to ejguan/data
that referenced
this pull request
May 26, 2023
Summary: A retry of meta-pytorch#1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: meta-pytorch#1170 Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: 7f4d208e3ff0a6bea4688862f7b8d5456af8e7f6
facebook-github-bot
pushed a commit
that referenced
this pull request
May 26, 2023
Summary: A retry of #1147 - Add pause, resume, limit API to MultiProcessingReadingService to support miniepoch API. - When limit is requested, `IterQueueWrapper` will make sure only `limit` number of requests are sent to worker process and dispatching proccess. - Consolidate a few API/messages - reset and reset_epoch is merged as a single message - Process reset function is shared for both worker process and dispatching process - For pause/resume/limit/reset_epoch, add a counter to sync between loops to make sure the DataPipe graph is in-place modified once. - Remove unused thread eventloop Pull Request resolved: #1170 Reviewed By: NivekT Differential Revision: D45666912 Pulled By: ejguan fbshipit-source-id: a22f0c74c78423b1833d5b2cf8cbdab6b9eb9ea0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
pause,resume,limitAPI toMultiProcessingReadingServiceto support miniepoch API.All tests should be passing in
test/dataloader2/test_mrps.pyDifferential Revision: D45289736