[DataLoader2] Handle MapDataPipe by converting to IterDataPipe internally by default#1146
Closed
NivekT wants to merge 1 commit intogh/NivekT/123/basefrom
Closed
[DataLoader2] Handle MapDataPipe by converting to IterDataPipe internally by default#1146NivekT wants to merge 1 commit intogh/NivekT/123/basefrom
MapDataPipe by converting to IterDataPipe internally by default#1146NivekT wants to merge 1 commit intogh/NivekT/123/basefrom
Conversation
…ally by default [ghstack-poisoned]
Contributor
Author
|
@ejguan Let me know what you think of this. |
MapDataPipe by converting to IterDataPipe internally by default
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
MapDataPipeby converting toIterDataPipeinternally by default #1146Fixes #1143
I believe since
DataLoader2would always calliter(map_data_pipe)at some point anyway, it should make no different to perform the conversion withto_iter_datapipe()within__init__.This will also allow prefetchers to be attached to the DataPipe.
Please let me know if this may be BC-breaking.
Differential Revision: D45452068