[DataPipe] Implement pause/resume for FullSync#1130
Closed
NivekT wants to merge 3 commits intogh/NivekT/121/basefrom
Closed
[DataPipe] Implement pause/resume for FullSync#1130NivekT wants to merge 3 commits intogh/NivekT/121/basefrom
pause/resume for FullSync#1130NivekT wants to merge 3 commits intogh/NivekT/121/basefrom
Conversation
[ghstack-poisoned]
pause/resume for FullSync
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D45015591](https://our.internmc.facebook.com/intern/diff/D45015591) [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
approved these changes
Apr 17, 2023
Contributor
ejguan
left a comment
There was a problem hiding this comment.
As long as the implementation doesn't invalidate the timeout from FullSync (if not all of ranks have received data at the same iteration), it should be good. Stamping on it and pls test it with the removing delegation PR.
Differential Revision: [D45015591](https://our.internmc.facebook.com/intern/diff/D45015591) [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
pause/resumefor FullSync #1130Differential Revision: D45015591