Add long description to setup.py#1094
Closed
MoritzThomasHuebner wants to merge 2 commits intometa-pytorch:mainfrom
Closed
Add long description to setup.py#1094MoritzThomasHuebner wants to merge 2 commits intometa-pytorch:mainfrom
MoritzThomasHuebner wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
ejguan
approved these changes
Mar 17, 2023
Contributor
ejguan
left a comment
There was a problem hiding this comment.
Thank you. Could you pls run python setup.py bdist_wheel on your local env to see the result?
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Mar 17, 2023
Contributor
Contributor
Validated on my local environment after the merge |
NivekT
pushed a commit
that referenced
this pull request
Apr 19, 2023
Summary: Fixes #1088 ### Changes - Added the README.md as a long description in the `setup.py` - Added `long_description_content_type` field Co-Authored by: Martin Achtner <martin.achtner@tngtech.com> Jad Saliba <jad.saliba@tngtech.com> Pull Request resolved: #1094 Reviewed By: NivekT Differential Revision: D44166989 Pulled By: ejguan fbshipit-source-id: 24fafc170a825372356aba8c3f086a360902b6c9
ejguan
pushed a commit
that referenced
this pull request
Apr 20, 2023
Summary: Fixes #1088 ### Changes - Added the README.md as a long description in the `setup.py` - Added `long_description_content_type` field Co-Authored by: Martin Achtner <martin.achtner@tngtech.com> Jad Saliba <jad.saliba@tngtech.com> Pull Request resolved: #1094 Reviewed By: NivekT Differential Revision: D44166989 Pulled By: ejguan fbshipit-source-id: 24fafc170a825372356aba8c3f086a360902b6c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1088
Changes
setup.pylong_description_content_typefieldCo-Authored by:
Martin Achtner martin.achtner@tngtech.com
Jad Saliba jad.saliba@tngtech.com