Update C++ standard to 17#1051
Closed
cyyever wants to merge 1 commit intometa-pytorch:mainfrom
cyyever:cxx17
Closed
Update C++ standard to 17#1051cyyever wants to merge 1 commit intometa-pytorch:mainfrom cyyever:cxx17
cyyever wants to merge 1 commit intometa-pytorch:mainfrom
cyyever:cxx17
Conversation
ejguan
approved these changes
Feb 27, 2023
Contributor
ejguan
left a comment
There was a problem hiding this comment.
LGTM, thanks. The AWS tests passed.
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Feb 27, 2023
Contributor
NivekT
pushed a commit
that referenced
this pull request
Feb 28, 2023
Summary: Following the change in PyTorch core. pytorch/pytorch@87e4a08 Pull Request resolved: #1051 Reviewed By: NivekT Differential Revision: D43629811 Pulled By: ejguan fbshipit-source-id: 9fb43b055ec5731c5854f69e9902d46764411092
ejguan
pushed a commit
that referenced
this pull request
Feb 28, 2023
Summary: Following the change in PyTorch core. pytorch/pytorch@87e4a08 Pull Request resolved: #1051 Reviewed By: NivekT Differential Revision: D43629811 Pulled By: ejguan fbshipit-source-id: 9fb43b055ec5731c5854f69e9902d46764411092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the change in PyTorch core.
pytorch/pytorch@87e4a08