[Doc] Add round robin sharding documentation#1050
Closed
NivekT wants to merge 2 commits intogh/NivekT/108/basefrom
Closed
[Doc] Add round robin sharding documentation#1050NivekT wants to merge 2 commits intogh/NivekT/108/basefrom
NivekT wants to merge 2 commits intogh/NivekT/108/basefrom
Conversation
[ghstack-poisoned]
ejguan
approved these changes
Feb 27, 2023
Contributor
ejguan
left a comment
There was a problem hiding this comment.
This looks awesome. Thank you so much. Let's cherrypick it before the final branch cut.
Also fixed some wording and typos [ghstack-poisoned]
Contributor
Author
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
NivekT
added a commit
that referenced
this pull request
Feb 28, 2023
Summary: Pull Request resolved: #1050 Also fixed some wording and typos Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D43625322 Pulled By: NivekT fbshipit-source-id: 37adee2d72fdf20c12560eb2134ef93749ac0293
ejguan
pushed a commit
that referenced
this pull request
Feb 28, 2023
Summary: Pull Request resolved: #1050 Also fixed some wording and typos Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D43625322 Pulled By: NivekT fbshipit-source-id: 37adee2d72fdf20c12560eb2134ef93749ac0293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Also fixed some wording and typos
Differential Revision: D43625322