Closed
Conversation
NivekT
approved these changes
Feb 23, 2023
Contributor
NivekT
left a comment
There was a problem hiding this comment.
Seems reasonable to add to me. Only one nit comment. Thanks!
Contributor
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
NivekT
pushed a commit
that referenced
this pull request
Feb 28, 2023
Summary: As mentioned in #256 it would be useful to have this in all dp that use a `key_fn`. ### Changes - Add keep_key option to `MapKeyZipper` - Test for the new option - Improve example in documentation by using sphinx doctest Pull Request resolved: #1042 Reviewed By: ejguan Differential Revision: D43550124 Pulled By: NivekT fbshipit-source-id: 453418560dd586ebb9ce42dd27eb1bc86eb734d0
ejguan
pushed a commit
that referenced
this pull request
Feb 28, 2023
Summary: As mentioned in #256 it would be useful to have this in all dp that use a `key_fn`. ### Changes - Add keep_key option to `MapKeyZipper` - Test for the new option - Improve example in documentation by using sphinx doctest Pull Request resolved: #1042 Reviewed By: ejguan Differential Revision: D43550124 Pulled By: NivekT fbshipit-source-id: 453418560dd586ebb9ce42dd27eb1bc86eb734d0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #256 it would be useful to have this in all dp that use a
key_fn.Changes
MapKeyZipper