Update Prefetcher and Implement PinMemory IterDataPipe#1014
Closed
ejguan wants to merge 8 commits intometa-pytorch:mainfrom
Closed
Update Prefetcher and Implement PinMemory IterDataPipe#1014ejguan wants to merge 8 commits intometa-pytorch:mainfrom
ejguan wants to merge 8 commits intometa-pytorch:mainfrom
Conversation
ejguan
commented
Feb 15, 2023
NivekT
reviewed
Feb 15, 2023
f42a19d to
38fe408
Compare
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
I need to rebase onto #1003 after it's landed. |
NivekT
reviewed
Feb 16, 2023
d3863ed to
956748c
Compare
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Feb 16, 2023
| import torch | ||
|
|
||
|
|
||
| def pin_memory_fn(data, device=None): |
Contributor
There was a problem hiding this comment.
Non-blocking: A short docstring and add this to torchdata.datapipes.utils.rst will be nice.
956748c to
1beb49f
Compare
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Feb 17, 2023
Contributor
NivekT
left a comment
There was a problem hiding this comment.
It will be nice to mention pin memory and what it does to users in tutorial at some point, but this is beyond the scope of this PR.
Contributor
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Feb 21, 2023
…1014) Summary: Fixes meta-pytorch#1013 ## Changes - Simplify the control flow of prefetcher - Delay Exception raised from thread worker to main thread in `__iter__` - Stop prefetching whenever Exception is received - As long as `stop_iteration` is not turned on or `buffer` is not empty, continue yielding data from `__iter__`. - Add serialization test - Add `PinMemory` DataPipe - `is_replciable() -> False` to keep it in the main process - Add unit tests - Update `test_proto_multi_rs.py` to `test_mprs.py` Pull Request resolved: meta-pytorch#1014 Reviewed By: NivekT Differential Revision: D43329696 Pulled By: ejguan fbshipit-source-id: da4326dbe2388f4e23b9a1a3a5c43da09d29185a
ejguan
added a commit
that referenced
this pull request
Feb 21, 2023
Summary: Fixes #1013 ## Changes - Simplify the control flow of prefetcher - Delay Exception raised from thread worker to main thread in `__iter__` - Stop prefetching whenever Exception is received - As long as `stop_iteration` is not turned on or `buffer` is not empty, continue yielding data from `__iter__`. - Add serialization test - Add `PinMemory` DataPipe - `is_replciable() -> False` to keep it in the main process - Add unit tests - Update `test_proto_multi_rs.py` to `test_mprs.py` Pull Request resolved: #1014 Reviewed By: NivekT Differential Revision: D43329696 Pulled By: ejguan fbshipit-source-id: da4326dbe2388f4e23b9a1a3a5c43da09d29185a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1013
Changes
__iter__stop_iterationis not turned on orbufferis not empty, continue yielding data from__iter__.PinMemoryDataPipeis_replciable() -> Falseto keep it in the main processtest_proto_multi_rs.pytotest_mprs.py