kommander-thanos/karma: Cleanup job hook weights#384
Merged
sebbrandt87 merged 2 commits intoJan 29, 2020
Merged
Conversation
eb46235 to
9ba3613
Compare
branden
approved these changes
Jan 29, 2020
Contributor
sebbrandt87
approved these changes
Jan 29, 2020
samvantran
approved these changes
Jan 29, 2020
mesosphere-teamcity
pushed a commit
that referenced
this pull request
Jan 29, 2020
…up_weights_D2IQ-62971 kommander-thanos/karma: Cleanup job hook weights
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the cleanup job hook weights for kommander-thanos and kommander-karma, so that sa/clusterroles are all set up prior to these cleanup scripts to avoid permission errors.
Testing
Please see the Testing section of #386