Document and test env vars a bit better#6827
Merged
dcbaker merged 1 commit intomesonbuild:masterfrom Apr 3, 2022
Merged
Conversation
Ericson2314
commented
Mar 23, 2020
Comment on lines
+6339
to
+6516
| env = { | ||
| 'CC_FOR_BUILD': '"' + os.path.join(testdir, 'build_wrapper.py') + '"', | ||
| 'CC': '"' + os.path.join(testdir, 'host_wrapper.py') + '"', | ||
| } | ||
| crossfile = tempfile.NamedTemporaryFile(mode='w') | ||
| crossfile.write('''[binaries] | ||
| c = ['{0}'] | ||
| '''.format(os.path.join(testdir, 'host_wrapper.py'))) | ||
| crossfile.write('') |
Contributor
Author
There was a problem hiding this comment.
I don't have to change this test, as this is a non-breaking change. However, doing so makes it less redundant with the previous test, which exclusive uses the native and cross files with no environment variables.
b727296 to
7001c9e
Compare
Contributor
Author
|
@ePirat Let's not forget about this :). |
ePirat
reviewed
Apr 8, 2020
Contributor
ePirat
left a comment
There was a problem hiding this comment.
Sounds like a very good change to me, to be compatible with the existing conventions for these variables.
7001c9e to
969f7ee
Compare
969f7ee to
6c0bf2b
Compare
Ericson2314
added a commit
to Ericson2314/nixpkgs
that referenced
this pull request
Apr 28, 2020
See comment in code and the PR it references, mesonbuild/meson#6827, for details. We can remove entries from the cross file because they will be gotten from env vars now.
This was referenced May 7, 2020
jtojnar
reviewed
May 15, 2020
6c0bf2b to
52f1107
Compare
52f1107 to
d6d420d
Compare
Codecov Report
@@ Coverage Diff @@
## master #6827 +/- ##
==========================================
- Coverage 66.16% 66.12% -0.04%
==========================================
Files 406 406
Lines 86660 86660
Branches 19144 19144
==========================================
- Hits 57335 57307 -28
- Misses 24915 24933 +18
- Partials 4410 4420 +10
Continue to review full report at Codecov.
|
dcbaker
approved these changes
Apr 3, 2022
Member
|
Updating the tests to help with env2cross seems like a great idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this PR was first opened, just about everything it was supposed to do already happened, so now it is just refining the docs and tests for existing behavior.