fix(routing): prevent licensed users from rebroadcasting packets to or from unlicensed users#9958
Merged
Merged
Conversation
… unlicensed or unknown users
…r from unlicensed users
Collaborator
Author
|
@GUVWAF does this make sense? |
GUVWAF
approved these changes
Mar 20, 2026
GUVWAF
left a comment
Member
There was a problem hiding this comment.
Yes, I guess it makes sense to make it more strict like this.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates routing-level packet filtering for licensed (“ham”) nodes to reduce unintended rebroadcasting of traffic involving unlicensed users.
Changes:
- Extend the licensed-node rebroadcast drop condition to also block packets addressed to known-unlicensed users (not just packets from them).
- Update the associated debug log message and inline comment to reflect “to or from” behavior.
fifieldt
approved these changes
Mar 20, 2026
oumike
pushed a commit
to oumike/firmware
that referenced
this pull request
Mar 25, 2026
…r from unlicensed users (meshtastic#9958) * fix(routing): prevent licensed users from rebroadcasting packets from unlicensed or unknown users * fix(routing): prevent licensed users from rebroadcasting packets to or from unlicensed users --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
oumike
pushed a commit
to oumike/firmware
that referenced
this pull request
Mar 27, 2026
…r from unlicensed users (meshtastic#9958) * fix(routing): prevent licensed users from rebroadcasting packets from unlicensed or unknown users * fix(routing): prevent licensed users from rebroadcasting packets to or from unlicensed users --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
thebentern
added a commit
that referenced
this pull request
Mar 31, 2026
…r from unlicensed users (#9958) * fix(routing): prevent licensed users from rebroadcasting packets from unlicensed or unknown users * fix(routing): prevent licensed users from rebroadcasting packets to or from unlicensed users --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
skrashevich
pushed a commit
to skrashevich/meshtastic-firmware
that referenced
this pull request
Apr 4, 2026
…r from unlicensed users (meshtastic#9958) * fix(routing): prevent licensed users from rebroadcasting packets from unlicensed or unknown users * fix(routing): prevent licensed users from rebroadcasting packets to or from unlicensed users --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen reports that ham nodes are rebroadcasting packets from non-ham users.
Looking at the logic, it appears that if non-licensed senders aren't in the nodedb (so UserLicenseStatus::Unknown) and are broadcasting to a known (but not necessarily licensed) node, the packets will be relayed.
This change requires either the sender or recipient to be a known licensed user. The local_only setting will then make sure that no other packets are relayed.