Fix: Enable touch-to-backlight on T-Echo (not just T-Echo Plus)#9953
Merged
thebentern merged 2 commits intoMar 22, 2026
Conversation
The touch-to-backlight feature was gated behind TTGO_T_ECHO_PLUS, but the regular T-Echo has the same backlight pin (PIN_EINK_EN, P1.11). This changes the guard to use PIN_EINK_EN only, so any device with an e-ink backlight pin gets the feature. Fixes meshtastic#7630
Contributor
@okturan, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
|
|
thebentern
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes BaseUI’s touch-to-backlight behavior on the standard LilyGo T-Echo by removing an overly-specific compile-time guard that limited the feature to TTGO_T_ECHO_PLUS, even though the non-Plus T-Echo exposes the same e-ink backlight enable pin (PIN_EINK_EN).
Changes:
- Expand touch-to-backlight enablement from
TTGO_T_ECHO_PLUS && PIN_EINK_ENto any build that definesPIN_EINK_EN. - Update the inline comment to reflect the broader condition (“devices with e-ink backlight pin”).
thebentern
added a commit
that referenced
this pull request
Mar 22, 2026
The touch-to-backlight feature was gated behind TTGO_T_ECHO_PLUS, but the regular T-Echo has the same backlight pin (PIN_EINK_EN, P1.11). This changes the guard to use PIN_EINK_EN only, so any device with an e-ink backlight pin gets the feature. Fixes #7630 Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
…tastic#9953) The touch-to-backlight feature was gated behind TTGO_T_ECHO_PLUS, but the regular T-Echo has the same backlight pin (PIN_EINK_EN, P1.11). This changes the guard to use PIN_EINK_EN only, so any device with an e-ink backlight pin gets the feature. Fixes meshtastic#7630 Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7630
The touch-to-backlight feature was gated behind
TTGO_T_ECHO_PLUS, but theregular T-Echo has the same backlight pin (
PIN_EINK_EN, P1.11). This meantthe capacitive touch button did nothing useful on BaseUI for non-Plus T-Echo
devices.
This changes the guard from
defined(TTGO_T_ECHO_PLUS) && defined(PIN_EINK_EN)to just
defined(PIN_EINK_EN), so any device with an e-ink backlight pin getsthe feature.
InkHUD already drives this pin on the regular T-Echo without issues.
Tested on a LilyGo T-Echo v1 with BaseUI.
🤝 Attestations