Skip to content

hexDump: Add const to the buf parameter in hexDump.#9944

Merged
thebentern merged 1 commit into
meshtastic:developfrom
fw190d13:fix
Mar 19, 2026
Merged

hexDump: Add const to the buf parameter in hexDump.#9944
thebentern merged 1 commit into
meshtastic:developfrom
fw190d13:fix

Conversation

@fw190d13

@fw190d13 fw190d13 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

The function only reads the buffer, so marking it const clarifies intent and prevents accidental modification.

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

The function only reads the buffer, so marking it const clarifies intent
and prevents accidental modification.
@github-actions

Copy link
Copy Markdown
Contributor

@fw190d13, Welcome to Meshtastic!

Thanks for opening your first pull request. We really appreciate it.

We discuss work as a team in discord, please join us in the #firmware channel.
There's a big backlog of patches at the moment. If you have time,
please help us with some code review and testing of other PRs!

Welcome to the team 😄

@CLAassistant

CLAassistant commented Mar 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added first-contribution needs-review Needs human review enhancement New feature or request labels Mar 19, 2026
@thebentern thebentern merged commit 9f74fc1 into meshtastic:develop Mar 19, 2026
79 of 80 checks passed
thebentern pushed a commit that referenced this pull request Mar 19, 2026
The function only reads the buffer, so marking it const clarifies intent
and prevents accidental modification.
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
The function only reads the buffer, so marking it const clarifies intent
and prevents accidental modification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request first-contribution needs-review Needs human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants