Ensure infrastructure role-based minimums are coerced since they don't have scaling#9937
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the role-based minimum interval “floors” used when coercing telemetry and position broadcast intervals on default channels, so router roles (which don’t use congestion scaling) still get appropriately coarse minimums.
Changes:
- Make
min_default_telemetry_interval_secsandmin_default_broadcast_interval_secsrole-aware viaIF_ROUTER(...)(router/router_late getONE_DAY/2minimums). - Update NodeDB log/comment text to reflect role-aware coercion behavior.
- Add unit tests validating the role-aware minimum coercion values for ROUTER, ROUTER_LATE, and CLIENT roles.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/mesh/Default.h |
Makes default-channel minimum interval macros role-aware for router roles. |
src/mesh/NodeDB.cpp |
Adjusts log/comment text to match the new role-aware minimum semantics. |
test/test_default/test_main.cpp |
Adds tests asserting router vs client minimum interval behavior. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
…t have scaling (meshtastic#9937) * Ensure infrastructure role-based minimums are coerced since they don't have scaling * Add test * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was pointed out in a discussion, the infrastructure roles don't enforce scaling, so instead we must ensure that the interval floors are coerced in line with those courser-grained default broadcasts minimums.