Remove early return during scan of BME address for BMP sensors#9935
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts I2C device identification logic in ScanI2CTwoWire by modifying switch control-flow in the BME/BMP/DPS sensor detection path.
Changes:
- Removes an extra
break;in theBME_ADDRidentification switch, altering fallthrough behavior.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes I2C sensor detection for BMP388/BMP390 devices that respond with 0x00 to the BME/BMP ID register (0xD0) by preventing an unconditional exit after the DPS310 probe, allowing the subsequent BMP3xx/BMP280 detection logic to run (addresses issue #9811).
Changes:
- Removes the unconditional
breakafter the DPS310 check when0xD0returns0x00. - Adds a conditional
breakonly when a DPS310 is positively identified, otherwise falling through to the BMP3xx/BMP280 ID probe path.
You can also share your feedback on Copilot code review. Take the survey.
thebentern
added a commit
that referenced
this pull request
Mar 19, 2026
* Enable pre-hop drop handling by default * Remove early break if BME/DPS sensors are not detected at the BME address * revert sneaky change * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
…astic#9935) * Enable pre-hop drop handling by default * Remove early break if BME/DPS sensors are not detected at the BME address * revert sneaky change * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR may solve the issue highlighted in #9811