Skip to content

Add spoof detection for UDP packets in UdpMulticastHandler#9905

Merged
thebentern merged 4 commits into
meshtastic:developfrom
NomDeTom:no_u
Mar 15, 2026
Merged

Add spoof detection for UDP packets in UdpMulticastHandler#9905
thebentern merged 4 commits into
meshtastic:developfrom
NomDeTom:no_u

Conversation

@NomDeTom

Copy link
Copy Markdown
Collaborator

As per discussion.

@github-actions github-actions Bot added needs-review Needs human review enhancement New feature or request labels Mar 14, 2026
@Jorropo Jorropo requested a review from Copilot March 14, 2026 12:03
Comment thread src/mesh/udp/UdpMulticastHandler.h Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds basic spoof/loopback suppression for incoming UDP-multicast mesh packets, improving safety when bridging packets over LAN in Meshtastic’s UDP transport path.

Changes:

  • Rejects received UDP packets that claim a local origin (from == 0 or from == local node).
  • Logs and drops suspected spoofed local-origin packets before enqueuing to the router.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/mesh/udp/UdpMulticastHandler.h
Comment thread src/mesh/udp/UdpMulticastHandler.h Outdated
@thebentern thebentern merged commit 4890f70 into meshtastic:develop Mar 15, 2026
77 checks passed
thebentern pushed a commit that referenced this pull request Mar 19, 2026
* Add spoof detection for UDP packets in UdpMulticastHandler

* Implement isFromUs function for packet origin validation

* ampersand
andmadeira pushed a commit to andmadeira/meshtastic-firmware that referenced this pull request Mar 19, 2026
…c#9905)

* Add spoof detection for UDP packets in UdpMulticastHandler

* Implement isFromUs function for packet origin validation

* ampersand
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
…c#9905)

* Add spoof detection for UDP packets in UdpMulticastHandler

* Implement isFromUs function for packet origin validation

* ampersand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-review Needs human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants