Experiment: C++17 support#9874
Merged
Merged
Conversation
Removed include directive for mbedtls/error.h from build flags.
Jorropo
reviewed
Mar 10, 2026
Jorropo
added a commit
to Jorropo/firmware
that referenced
this pull request
Mar 11, 2026
We should use make_unique in all similar cases in the future. We didn't in the past since we didn't had a C++ version high enough. Ben fixed this in meshtastic#9874
Jorropo
added a commit
to Jorropo/firmware
that referenced
this pull request
Mar 11, 2026
We should use make_unique in all similar cases in the future. We didn't in the past since we didn't had a C++ version high enough. Ben fixed this in meshtastic#9874
Jorropo
added a commit
to Jorropo/firmware
that referenced
this pull request
Mar 11, 2026
We should use make_unique in all similar cases in the future. We didn't in the past since we didn't had a C++ version high enough. Ben fixed this in meshtastic#9874
Jorropo
added a commit
to Jorropo/firmware
that referenced
this pull request
Mar 11, 2026
We should use make_unique in all similar cases in the future. We didn't in the past since we didn't had a C++ version high enough. Ben fixed this in meshtastic#9874
Jorropo
added a commit
to Jorropo/firmware
that referenced
this pull request
Mar 11, 2026
We should use make_unique in all similar cases in the future. We didn't in the past since we didn't had a C++ version high enough. Ben fixed this in meshtastic#9874
Jorropo
added a commit
to Jorropo/firmware
that referenced
this pull request
Mar 11, 2026
We should use make_unique in all similar cases in the future. We didn't in the past since we didn't had a C++ version high enough. Ben fixed this in meshtastic#9874
Collaborator
|
Once this is released, do we need an update to the LLM instructions? |
andmadeira
pushed a commit
to andmadeira/meshtastic-firmware
that referenced
this pull request
Mar 19, 2026
* Add C++17 support * Add C++17 runtime probes and update build configurations for STM32 and Portduino * Remove unflags * Update C++ standard flags across the platforms * Convert a couple of instances to structured bindings * NRF52 platform.txt to add C++17 support * Still need the unflags apparently * Remove C++17 runtime probe tests from test_main.cpp * Reconfigured doesnt need a nodiscard * Remove nodiscard attribute from init() method in RadioInterface * Remove mbedtls/error.h from build flags Removed include directive for mbedtls/error.h from build flags. * Fix IRAM overflow * Fix IRAM overflow * Add build flag to exclude MQTT from rak11200 * Update C++ standard from gnu17 to gnu++17
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
* Add C++17 support * Add C++17 runtime probes and update build configurations for STM32 and Portduino * Remove unflags * Update C++ standard flags across the platforms * Convert a couple of instances to structured bindings * NRF52 platform.txt to add C++17 support * Still need the unflags apparently * Remove C++17 runtime probe tests from test_main.cpp * Reconfigured doesnt need a nodiscard * Remove nodiscard attribute from init() method in RadioInterface * Remove mbedtls/error.h from build flags Removed include directive for mbedtls/error.h from build flags. * Fix IRAM overflow * Fix IRAM overflow * Add build flag to exclude MQTT from rak11200 * Update C++ standard from gnu17 to gnu++17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not in love with all of the unflags, but it seems to be the main way of making some of the platforms work.