Allow using Spreading Factors 5 and 6#9363
Conversation
@derpyspike, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
|
@derpyspike can you please create a PR against documentation, detailing the 2 new spread factors and that they don't work in 1st gen chips. |
2a59b9e to
ea66b40
Compare
| } | ||
|
|
||
| if (validatedLora.spread_factor < 7 || validatedLora.spread_factor > 12) { | ||
| if (validatedLora.spread_factor < 5 || validatedLora.spread_factor > 12) { |
There was a problem hiding this comment.
can you check for a 1st gen radio (SX127x, RF95) and refuse 5 and 6 in that case?
There was a problem hiding this comment.
@caveman99 I've updated the check to check for these, I've also included the detect/LoRaRadioType.h in the includes to use the radioType for this check.
… that don't support it.
|
@caveman99 OK, change made and docs PR opened. |
|
@thebentern Hi, I see you added conflicting logic to check for the Spreading Factor in your #9808 PR, should I integrate my check into that one? Or modify the LORA_SF_MIN on yours and leave mine as a separate check? |
|
Closed, and reopened in #10160 |
Modified AdminModule.cpp to allow setting Spreading Factor 5 and 6 in custom presets.
In modern LoRa chips like the SX1262 or LR1110 these seem to work without issues and I have tested both SF5 and SF6 extensively with Meshtastic (with this AdminModule change) even with 30 km links and everything seems to work fine.
🤝 Attestations