Increase default position broadcast intervals and enforce minimums for the public default channels#9236
Merged
Merged
Conversation
…r default channels
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces minimum broadcast interval enforcement for position broadcasts when sent over public default channels, addressing concerns about excessive position broadcasts on the shared mesh network infrastructure. The changes increase default position broadcast intervals and add logic to enforce these minimums.
Key changes:
- Added minimum broadcast interval constants (1 hour for regular broadcasts, 5 minutes for smart broadcasts)
- Updated default position broadcast interval from 15 minutes to 60 minutes for non-router devices
- Implemented enforcement logic in NodeDB constructor to coerce position intervals when using default channels
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mesh/Default.h | Adds new minimum interval constants and increases default broadcast interval from 15 to 60 minutes |
| src/mesh/NodeDB.cpp | Implements position broadcast interval enforcement for default channels, similar to existing telemetry enforcement |
| src/modules/PositionModule.h | Updates hardcoded default value (30 seconds) to use new constant (5 minutes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jp-bennett
approved these changes
Jan 9, 2026
jp-bennett
left a comment
Collaborator
There was a problem hiding this comment.
Seems pretty reasonable. Doesn't break anything on private channels.
vidplace7
approved these changes
Jan 9, 2026
fifieldt
approved these changes
Jan 9, 2026
RCGV1
approved these changes
Jan 9, 2026
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
…-increase Increase default position broadcast intervals and enforce minimums for the public default channels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new minimum interval constants for position broadcasts and ensures that these minimums are enforced when broadcasting positions over default channels. It also updates the configuration logic to use these new constants, improving consistency and preventing excessive position broadcasts.
Position broadcast interval enforcement:
Default.hfor minimum broadcast intervals:min_default_broadcast_interval_secs(1 hour) andmin_default_broadcast_smart_minimum_interval_secs(5 minutes), and updated the default values for position broadcast intervals.NodeDB::NodeDB()to enforce the new minimum broadcast intervals when positions are sent over default channels, ensuring position broadcasts are not too frequent.