Fix TSL2591 detection by adding command bit to register read#9215
Merged
fifieldt merged 1 commit intoJan 8, 2026
Conversation
|
|
|
|
fifieldt
approved these changes
Jan 8, 2026
vicliu624
pushed a commit
to vicliu624/firmware
that referenced
this pull request
Jan 13, 2026
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSL2591 requires the command bit (0xA0) to be OR'd with the register address when reading. Without this, the ID register read returns invalid data, causing misdetection as TSL2561.
Fixes #9124