Skip to content

Add option to Mute/Unmute Channel to BaseUI#9194

Merged
thebentern merged 3 commits into
developfrom
baseui_mutechannel
Jan 6, 2026
Merged

Add option to Mute/Unmute Channel to BaseUI#9194
thebentern merged 3 commits into
developfrom
baseui_mutechannel

Conversation

@Xaositek

@Xaositek Xaositek commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add option to Mute/Unmute Channel to BaseUI
  • Is gated to confirm that full chat list or DM views does not show this option
  • Leverages Mute: channels #7957 functionality to mute popups and sounds

@Xaositek Xaositek self-assigned this Jan 6, 2026
@Xaositek Xaositek added enhancement New feature or request baseui Issues directly related to BaseUI labels Jan 6, 2026
@Xaositek Xaositek marked this pull request as ready for review January 6, 2026 15:53
@thebentern thebentern requested a review from Copilot January 6, 2026 16:23
Copilot AI reviewed Jan 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Mute/Unmute Channel option to the message response menu in the BaseUI, allowing users to mute or unmute specific channels directly from the interface. The feature is conditionally displayed, excluding it from the ALL chats view and DIRECT message views.

Key Changes:

  • Added MuteChannel option to the message response menu enum
  • Implemented conditional display logic to show/hide the mute option based on view mode
  • Added toggle functionality to change the mute state of the current channel

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/graphics/draw/MenuHandler.cpp Outdated
Comment thread src/graphics/draw/MenuHandler.cpp Outdated
Comment thread src/graphics/draw/MenuHandler.cpp
Comment thread src/graphics/draw/MenuHandler.cpp
Comment thread src/graphics/draw/MenuHandler.cpp
@HarukiToreda

HarukiToreda commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

I haven't looked at the code yet, but are we muting the sound notification? or the autofocus jump to the channel conversation when a message arrives? I suggest clarifying on the description.

@Xaositek

Xaositek commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

I haven't looked at the code yet, but are we muting the sound notification? or the autofocus jump to the channel conversation when a message arrives? I suggest clarifying on the description.

Yes sound and alert notifications were suppressed in #7957 but we had no way to actually mute a Channel or take advantage of this functionality

@Xaositek Xaositek marked this pull request as draft January 6, 2026 16:55
@Xaositek Xaositek marked this pull request as ready for review January 6, 2026 17:25
ford-jones
ford-jones approved these changes Jan 6, 2026
View reviewed changes

@ford-jones ford-jones left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Jason 🙂

@thebentern thebentern merged commit 9c1d55c into develop Jan 6, 2026
75 checks passed
@Xaositek Xaositek deleted the baseui_mutechannel branch January 6, 2026 21:32
vicliu624 pushed a commit to vicliu624/firmware that referenced this pull request Jan 13, 2026
@Xaositek @vicliu624
Add option to Mute/Unmute Channel to BaseUI (meshtastic#9194)
cdfc4bf
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
@Xaositek
Add option to Mute/Unmute Channel to BaseUI (meshtastic#9194)
4534789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@thebentern thebentern thebentern approved these changes
@HarukiToreda HarukiToreda HarukiToreda approved these changes
+1 more reviewer
@ford-jones ford-jones ford-jones approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Xaositek Xaositek

Labels

baseui Issues directly related to BaseUI enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Xaositek @HarukiToreda @thebentern @ford-jones