RadioInterface::getRetransmissionMsec now handles encrypted packets c…#9184
Merged
Conversation
Contributor
Author
|
For some reason, I cannot add a tag to this Merge Request, should be 'bugfix'. Also, cannot run the formatter for some reason. |
Contributor
Author
|
I now realize that the |
vicliu624
pushed a commit
to vicliu624/firmware
that referenced
this pull request
Jan 13, 2026
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a one line PR (no issue created) that changes
RadioInterface::getRetransmissionMsecto handle the case of the packet being encrypted. This method is called by NextHopRouter when adding a packet for retranmssion. When the node is at least one hop away from the sending node, the packet handed to this method is encrypted.When the packet is encrypted, the current code throws an error
Panic: can't encode protobuf reason='bytes size exceeded'because of the call topb_encode_to_bytes. When this happens whatever value that gets placed innumbytesby this method results in the packet never being retransmitted about 90% of time (at least in my tests).The fix sets the
numbytesvalue to the correct size of the encrypted packet if it is encrypted.🤝 Attestations