Skip to content

Fixed shouldFilterReceived function to check prev relay according to the function definition#9168

Merged
thebentern merged 1 commit into
meshtastic:developfrom
strngr:fix/zero-hops-between-favorite-client-base-nodes
Jan 4, 2026
Merged

Fixed shouldFilterReceived function to check prev relay according to the function definition#9168
thebentern merged 1 commit into
meshtastic:developfrom
strngr:fix/zero-hops-between-favorite-client-base-nodes

Conversation

@strngr

@strngr strngr commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

Function shouldDecrementHopLimit definition states that hop_limit should not be decreased if prev relay has one of the following roles:

  • ROUTER
  • ROUTER_LATE
  • CLIENT_BASE

The function implementation only checks if it is ROUTER or ROUTER_LATE.

I noticed this bug because I have two static nodes on different frequencies with role CLIENT_BASE, which have favorited each other. These nodes mesh over UDP and work as a bridge between the frequencies. In this setup, one hop was always lost when packets go through the bridge. After the fix the issue is gone.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)
    • Ebyte E32 + ESP32S3 based

@CLAassistant

CLAassistant commented Jan 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@strngr strngr marked this pull request as ready for review January 3, 2026 19:02
@strngr strngr force-pushed the fix/zero-hops-between-favorite-client-base-nodes branch from 78e6bca to e18f37b Compare January 3, 2026 21:17
@thebentern thebentern added the bugfix Pull request that fixes bugs label Jan 3, 2026
@thebentern thebentern merged commit 25bdefe into meshtastic:develop Jan 4, 2026
72 checks passed
@strngr strngr changed the title Fixed shouldFilterReceived function to check prev relay accoding to the function definition Fixed shouldFilterReceived function to check prev relay according to the function definition Jan 4, 2026
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants