Mark implicit ACK for MQTT as MQTT transport#8939
Merged
Merged
Conversation
thebentern
approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the MQTT implicit ACK mechanism to mark ACK packets with the MQTT transport type, preventing premature termination of retransmissions and ensuring proper fallback to flooding from the next hop.
Key Changes:
- Exposes
allocAckNakmethod in RoutingModule for direct ACK packet manipulation - Updates MQTT.cpp to set
transport_mechanismto MQTT for implicit ACKs - Removes trailing whitespace from two files
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mqtt/MQTT.cpp | Modified to use allocAckNak directly and set transport_mechanism to TRANSPORT_MQTT for implicit ACKs |
| src/modules/RoutingModule.h | Added public allocAckNak method declaration |
| src/modules/RoutingModule.cpp | Implemented allocAckNak method that delegates to parent class |
| src/platform/nrf52/main-nrf52.cpp | Removed trailing whitespace from comment |
| src/mesh/MeshModule.h | Removed trailing whitespace from function declaration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
MQTT might still be causing an ACK which stops the Lora retransmissions. MQTT generates new packet id=3458476566 (0xce242a16) and it looks like that packet is responsible for the |
Member
Author
|
Ah, I see, indeed in the firmware/src/mesh/ReliableRouter.cpp Line 99 in bcfe069 |
Member
Author
|
This should be fixed now in the latest commit. |
fifieldt
approved these changes
Dec 12, 2025
thebentern
approved these changes
Dec 12, 2025
thebentern
added a commit
that referenced
this pull request
Dec 12, 2025
Contributor
|
@GUVWAF the test |
Member
Author
|
@thebentern Ah, I think it should still work because the ACK is still generated, only the retransmissions are not stopped. But I think it's because the test expects it to be sent with firmware/test/test_mqtt/MQTT.cpp Line 89 in 68250dc |
scobert969
pushed a commit
to zeropt/meshtastic-firmware
that referenced
this pull request
Dec 22, 2025
* Mark implicit ACK for MQTT as MQTT transport * TRUNK * Fix build * Make sure implicit ACKs from MQTT do not stop retransmissions in ReliableRouter --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
* Mark implicit ACK for MQTT as MQTT transport * TRUNK * Fix build * Make sure implicit ACKs from MQTT do not stop retransmissions in ReliableRouter --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
…astic#8947) * Mark implicit ACK for MQTT as MQTT transport * TRUNK * Fix build * Make sure implicit ACKs from MQTT do not stop retransmissions in ReliableRouter --------- Co-authored-by: GUVWAF <78759985+GUVWAF@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid it stopping retransmissions and hence not falling back to flooding from next-hop.