Fix #8899 [Bug]: [TloraPager] RotaryEncoder crash#8933
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in the RotaryEncoder implementation on the TLoraPager device by adding proper lifecycle management and light sleep support for ESP32 platforms.
Key Changes:
- Added destructor and proper cleanup for RotaryEncoder resources
- Implemented light sleep callbacks to properly detach/reattach interrupts during sleep cycles
- Added virtual destructor to InputPollable base class for proper polymorphic deletion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/input/RotaryEncoderImpl.h | Added destructor, light sleep callback methods, and observer members for sleep notifications; marked class as final |
| src/input/RotaryEncoderImpl.cpp | Implemented destructor with cleanup logic, refactored interrupt management into dedicated methods, and added light sleep handlers |
| src/input/InputBroker.h | Added virtual destructor to InputPollable base class to enable proper cleanup through polymorphism |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
The checks failed not because of changes in the last commit: |
mverch67
approved these changes
Dec 11, 2025
scobert969
pushed a commit
to zeropt/meshtastic-firmware
that referenced
this pull request
Dec 22, 2025
…ic#8933) * Fix meshtastic#8899 [Bug]: [TloraPager] RotaryEncoder crash * Apply Copilot review --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
…ic#8933) * Fix meshtastic#8899 [Bug]: [TloraPager] RotaryEncoder crash * Apply Copilot review --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8899
🤝 Attestations