Use truncated position for smart position#8906
Merged
Merged
Conversation
jp-bennett
approved these changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Just FYI as this may be another edge case but I'm not into GPS code in Meshtastic - GPS devices and phones also report DOP (dilution of precision) and we should not trigger smart position send if previous and new position are within uncertainty radius of GPS position. I think someone a week ago reported here a situation when node with poor GPS reception "travels" constantly on a map and sends unnecesary position updates. |
thebentern
approved these changes
Dec 10, 2025
scobert969
pushed a commit
to zeropt/meshtastic-firmware
that referenced
this pull request
Dec 22, 2025
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have imprecise location and smart position on lets not send smart position even if we move if our new position will get truncated to the previous position. We now take into account truncating when deciding the distance travelled for smart pos.
Tested by walking around and sending client notification if the moved distance is greater than the threshold but the truncated position isnt.
This is useful for reducing the amount of positions that are sent.
🤝 Attestations