Skip to content

Fix #8883 (lora-Pager fter playing the notification, voltage does not disappear from the speaker)#8884

Merged
thebentern merged 2 commits into
meshtastic:developfrom
polarikus:8883
Dec 7, 2025
Merged

Fix #8883 (lora-Pager fter playing the notification, voltage does not disappear from the speaker)#8884
thebentern merged 2 commits into
meshtastic:developfrom
polarikus:8883

Conversation

@polarikus

@polarikus polarikus commented Dec 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #8883

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-LoraPager

@CLAassistant

CLAassistant commented Dec 7, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@polarikus

polarikus commented Dec 7, 2025

Copy link
Copy Markdown
Contributor Author

If this solution doesn't work for you, let's think about alternatives. My suggestions:

  1. Add a new method to AudioThread, something like "enableSpeaker", and call it where needed in NotificationModule.cpp.
  2. Move the power management of EXPANDS_AMP_EN completely to NotificationModule, but that might not look right - it doesn't seem like its responsibility.
  3. Move the low-level control of EXPANDS_AMP_EN somewhere else, for example, add a wrapper around AudioOutput.

@polarikus polarikus changed the title Fix #8883 Fix #8883 (lora-Pager fter playing the notification, voltage does not disappear from the speaker) Dec 7, 2025
@thebentern thebentern requested a review from mverch67 December 7, 2025 11:26
@thebentern thebentern added the bugfix Pull request that fixes bugs label Dec 7, 2025
mverch67
mverch67 approved these changes Dec 7, 2025
View reviewed changes

@mverch67 mverch67 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. If audioThread->stop() would never be called it would also leak memory (rtttlFile) which was allocated in beginRttl().

@thebentern thebentern merged commit 2ae3911 into meshtastic:develop Dec 7, 2025
78 of 80 checks passed
@polarikus polarikus deleted the 8883 branch December 8, 2025 06:57
@mverch67 mverch67 mentioned this pull request Dec 8, 2025
Closed
3 tasks
ponzano pushed a commit to Meshlink-Team/meshlink-firmware that referenced this pull request Dec 8, 2025
@polarikus @ponzano
Fix meshtastic#8883 (lora-Pager fter playing the notification, voltag…
47cd0e5 
…e does not disappear from the speaker) (meshtastic#8884)

* Fix meshtastic#8883

* Fix crash when delete not inicialized rtttlFile
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
@polarikus
Fix meshtastic#8883 (lora-Pager fter playing the notification, voltag…
9d68cb3 
…e does not disappear from the speaker) (meshtastic#8884)

* Fix meshtastic#8883

* Fix crash when delete not inicialized rtttlFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thebentern thebentern thebentern approved these changes
@mverch67 mverch67 mverch67 approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Tlora-Pager fter playing the notification, voltage does not disappear from the speaker

4 participants

@polarikus @CLAassistant @thebentern @mverch67