Reduce key duplication by enabling hardware RNG#8803
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a portable HardwareRNG helper to improve random number generation across platforms by tapping into hardware RNG sources (NRF52 crypto RNG, ESP32 TRNG, RP2040 hwrand, Portduino host RNG) and optionally mixing in modem-provided entropy. The goal is to reduce key duplication issues on NRF devices by stirring hardware bytes into CryptRNG during key generation.
Key changes:
- Added
HardwareRNGnamespace withfill()andseed()functions for platform-agnostic hardware entropy access - Integrated hardware entropy into
CryptoEngine::generateKeyPair()to strengthen key generation - Exposed
RadioLibInterface::randomBytes()to allow modem entropy mixing when radios are initialized - Updated NRF52, RP2040, and Portduino platform initialization to use the new
HardwareRNG::seed()helper
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/mesh/HardwareRNG.h |
New header defining the HardwareRNG interface with fill() and seed() functions |
src/mesh/HardwareRNG.cpp |
Implementation providing platform-specific hardware RNG access with optional radio entropy mixing |
src/mesh/RadioLibInterface.h |
Added public randomBytes() method declaration for exposing modem entropy |
src/mesh/RadioLibInterface.cpp |
Implemented randomBytes() to fetch entropy from LoRa modem via RadioLib API |
src/mesh/CryptoEngine.cpp |
Integrated HardwareRNG to stir 64 bytes of hardware entropy into CryptRNG during key generation |
src/platform/nrf52/main-nrf52.cpp |
Replaced direct nRFCrypto RNG calls with HardwareRNG::seed() |
src/platform/rp2xx0/main-rp2xx0.cpp |
Added HardwareRNG::seed() call alongside existing hwrand32 usage |
src/platform/portduino/PortduinoGlue.cpp |
Added HardwareRNG::seed() calls in both simulated and native modes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
I particularly like that this is just stirring in another potential randomness source. Will go through it in more detail as I am able. |
jp-bennett
reviewed
Nov 30, 2025
phaseloop
reviewed
Dec 3, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
I'll be happy if someone can take over this and get it live - we've got three new same-pubkey NRFs in the town nowadays |
4 tasks
Collaborator
I like basically about this approach, and it's clearly needed. I'll take over and get it pushed across the line. Thanks! |
Use micros() for worst case random seed for nrf52 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NomDeTom
pushed a commit
to NomDeTom/MeshtasticFirmware
that referenced
this pull request
Apr 14, 2026
* Reduce key duplication by enabling hardware RNG * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Use micros() for worst case random seed for nrf52 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor cleanup, remove dead code and clarify comment * trunk * Add useRadioEntropy bool, default false. --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
cvaldess
pushed a commit
to cvaldess/firmware
that referenced
this pull request
Apr 15, 2026
* Reduce key duplication by enabling hardware RNG * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Use micros() for worst case random seed for nrf52 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor cleanup, remove dead code and clarify comment * trunk * Add useRadioEntropy bool, default false. --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
thebentern
added a commit
that referenced
this pull request
Apr 21, 2026
* Reduce key duplication by enabling hardware RNG * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Use micros() for worst case random seed for nrf52 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor cleanup, remove dead code and clarify comment * trunk * Add useRadioEntropy bool, default false. --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
mariotti
pushed a commit
to mariotti/firmware
that referenced
this pull request
May 6, 2026
* Reduce key duplication by enabling hardware RNG * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Use micros() for worst case random seed for nrf52 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor cleanup, remove dead code and clarify comment * trunk * Add useRadioEntropy bool, default false. --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
* Reduce key duplication by enabling hardware RNG * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Use micros() for worst case random seed for nrf52 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor cleanup, remove dead code and clarify comment * trunk * Add useRadioEntropy bool, default false. --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤝 Attestations