Conversation
fixes regression for SX127x chips per @GUVWAF
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches the RadioLib dependency from a versioned PlatformIO registry package to a specific GitHub commit archive.
- Replaces
jgromes/RadioLib@7.4.0with a direct GitHub archive URL pointing to a specific commit (536c726) - Comments out the old versioned dependency instead of removing it
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -115,7 +115,8 @@ lib_deps = | |||
| [radiolib_base] | |||
| lib_deps = | |||
| # renovate: datasource=custom.pio depName=RadioLib packageName=jgromes/library/RadioLib | |||
There was a problem hiding this comment.
The renovate comment format is inconsistent with other git-based dependencies in this file. Other GitHub archive dependencies use datasource=git-refs instead of datasource=custom.pio, and they include the full package URL in packageName along with a gitBranch parameter.
For consistency with lines 64-73 and 123-124, this should be:
# renovate: datasource=git-refs depName=RadioLib packageName=https://github.com/jgromes/RadioLib gitBranch=master
https://github.com/jgromes/RadioLib/archive/536c7267362e2c1345be7054ba45e503252975ff.zip
Suggested change
| # renovate: datasource=custom.pio depName=RadioLib packageName=jgromes/library/RadioLib | |
| # renovate: datasource=git-refs depName=RadioLib packageName=https://github.com/jgromes/RadioLib gitBranch=master |
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
Change RadioLib to commit zip til 7.4.1+ is released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes regression for SX127x chips per @GUVWAF