Don't use unsigned integer type for negative SNR value#8432
Merged
Conversation
* Include RSSI in rangetest csv * Fix typo * Preserve csv column order --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
SNR-based contention windows are broken on systems with 64-bit long integers. Fixes #8430
|
|
|
|
GUVWAF
approved these changes
Oct 23, 2025
Contributor
|
Retargeted master. Looks like it's pulling other commits from develop, but those were some I was going to cherry pick anyway |
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
Don't use unsigned integer type for negative SNR value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RadioInterface::getCWsize(float snr) uses an unsigned integer type (uint32_t) to store a negative number, causing an integer overflow.On 32-bit systems this is later undone when stuffing the value back into a signed 32-bit
long.On systems with 64-bit
longs however, this will result in map() always returning the maximum CW size of 8 and no preference for nodes with low SNR.Fixes #8430
🤝 Attestations
Only tested code-snippet in isolation:
Before: https://www.onlinegdb.com/zTwCkEfEs
After: https://onlinegdb.com/qe4RSOjAqO