Skip to content

Actions: Simplify matrices, cleanup build_one_*#8218

Merged
fifieldt merged 1 commit into
meshtastic:developfrom
vidplace7:simplify-actions
Oct 7, 2025
Merged

Actions: Simplify matrices, cleanup build_one_*#8218
fifieldt merged 1 commit into
meshtastic:developfrom
vidplace7:simplify-actions

Conversation

@vidplace7

@vidplace7 vidplace7 commented Oct 5, 2025

Copy link
Copy Markdown
Member
  • Overhauled GitHub Actions matrix generation to move more of the complexity into generate_ci_matrix.py
    • This allows us to greatly simplify the build process (no more individually listing platforms one by one)
  • Updated workflows to reflect generate_ci_matrix.py changes.
  • Removed unnecessary steps in "build_one_*" workflows.
  • Set all portduino targets to 'extra' since they shouldn't be included in the setup matrix. (They've got their own workflows)

Tested within my fork 👍

@vidplace7 vidplace7 added the github_actions Pull requests that update GitHub Actions code label Oct 5, 2025
@vidplace7 vidplace7 requested a review from Copilot October 5, 2025 14:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the GitHub Actions CI matrix generation by consolidating architecture-specific build jobs into a single unified build job. The changes move complexity into the generate_ci_matrix.py script to reduce workflow duplication and streamline the build process.

  • Consolidates multiple architecture-specific build jobs into single build jobs
  • Updates matrix generation to use new CLI parameters and script location
  • Removes unnecessary workflow steps and duplicate job definitions

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/merge_queue.yml Simplifies matrix setup and consolidates all architecture builds into one job
.github/workflows/main_matrix.yml Updates matrix generation and replaces individual arch builds with unified build job
.github/workflows/build_one_target.yml Removes strategy/matrix from single-target builds and updates script path
.github/workflows/build_one_arch.yml Consolidates architecture-specific builds into single job with updated matrix handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/build_one_arch.yml Outdated
@vidplace7 vidplace7 force-pushed the simplify-actions branch 3 times, most recently from d8c589d to 9e19f64 Compare October 5, 2025 15:02
@vidplace7 vidplace7 marked this pull request as draft October 5, 2025 15:05
@vidplace7 vidplace7 force-pushed the simplify-actions branch 9 times, most recently from db8867a to e0604c0 Compare October 5, 2025 17:14
@vidplace7 vidplace7 marked this pull request as ready for review October 5, 2025 18:01
@vidplace7 vidplace7 force-pushed the simplify-actions branch 2 times, most recently from cb11da3 to 6d8a4a4 Compare October 6, 2025 23:21
Comment thread bin/generate_ci_matrix.py
@@ -1,28 +1,32 @@
#!/usr/bin/env python
#!/usr/bin/env python3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooooooo

@fifieldt fifieldt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid.

@DaneEvans DaneEvans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
it'll make the whole flow easier to follow too

@fifieldt fifieldt merged commit fc1737c into meshtastic:develop Oct 7, 2025
80 of 82 checks passed
fifieldt pushed a commit to fifieldt/meshtastic-firmware that referenced this pull request Oct 7, 2025
fifieldt added a commit that referenced this pull request Oct 7, 2025
Co-authored-by: Austin <vidplace7@gmail.com>
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants