Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes UDP build issues on nRF platform by conditionally compiling UDP-related code only when Ethernet support is available. The changes wrap the UDP implementation code with HAS_ETHERNET preprocessor conditionals to prevent compilation errors when Ethernet is not configured.
- Adds conditional compilation guards to prevent UDP code compilation when Ethernet is disabled
- Includes necessary configuration header to access the
HAS_ETHERNETmacro
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/platform/nrf52/AsyncUDP.h | Wraps header content with HAS_ETHERNET conditional and adds configuration include |
| src/platform/nrf52/AsyncUDP.cpp | Wraps implementation with HAS_ETHERNET conditional compilation guard |
thebentern
approved these changes
Jul 20, 2025
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 22, 2025
* fix UDP builds on nRF * fix rp2040 too
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 23, 2025
* fix UDP builds on nRF * fix rp2040 too
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
* fix UDP builds on nRF * fix rp2040 too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.