clean up double i2c init/scan code#7359
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the conditional compilation around I2C device scanning by merging multiple #if/#elif branches and removing explicit Wire/Wire1 initialization calls.
- Consolidate WIRE1 scan conditions into a single
#ifwith an OR. - Remove platform-specific
Wire/Wire1begin(),setSDA(), andsetSCL()calls. - Retain the WIRE scan under a distinct
#if defined(I2C_SDA)block.
Comments suppressed due to low confidence (1)
src/main.cpp:519
- The code now scans WIRE1 without any prior
Wire1.begin()or SDA/SCL configuration. Ensure thatWire1is initialized (e.g.,setSDA(),setSCL(), andbegin()) before callingscanPort.
i2cScanner->scanPort(ScanI2C::I2CPort::WIRE1);
fifieldt
approved these changes
Jul 16, 2025
fifieldt
left a comment
Member
There was a problem hiding this comment.
Nice find, I can't see any reason this should be duplicated.
caveman99
added a commit
that referenced
this pull request
Jul 16, 2025
This reverts commit 55fc4fc.
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 22, 2025
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 23, 2025
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.