Message frame New Message Options and Clock / TDeck / Brightness Refinements#7344
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new base menu for composing messages, refines clock display behavior for Chatter 2 and TDeck, and adjusts brightness and navigation logic across menus.
- Add
textMessageBaseMenuand route navigation when no incoming message exists - Update
ClockRendererto support CHATER_2 scaling and T_DECK y-offset, and remove an unused variable - Revise brightness support flags in
screenOptionsMenuand include T_DECK in TFT color picker - Shift header icon positioning and improve text message menu flow in
Screen::handleInputEvent
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/graphics/draw/MenuHandler.h | Declared new textMessageBaseMenu prototype |
| src/graphics/draw/MenuHandler.cpp | Implemented textMessageBaseMenu and updated menu flags |
| src/graphics/draw/ClockRenderer.cpp | Added scale and yOffset adjustments for CHATER_2 and T_DECK; removed unused line variable |
| src/graphics/SharedUIDisplay.cpp | Adjusted iconRightEdge calculation from -1 to -2 |
| src/graphics/Screen.cpp | Updated input handling to show base or response message menu |
Comments suppressed due to low confidence (3)
src/graphics/draw/MenuHandler.cpp:349
- [nitpick] The enum name 'optionsNumbers' and member 'enumEnd' are ambiguous. Consider renaming to something like 'TextMessageOption' and 'OptionCount' for clearer intent.
enum optionsNumbers { Back, Preset, Freetext, enumEnd };
src/graphics/draw/MenuHandler.cpp:347
- [nitpick] This new menu introduces user-facing options and a lambda callback. Consider adding unit or integration tests to validate both the Preset and Freetext branches and when
kb_foundis true or false.
void menuHandler::textMessageBaseMenu()
src/graphics/draw/ClockRenderer.cpp:290
- Double-check that this added
#endifmatches the correct#ifdef(SENSECAP_INDICATOR) and doesn’t prematurely close another block, which could lead to missing code under certain builds.
#endif
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 21, 2025
…nements (meshtastic#7344) * Clock updates and some TDeck corrections * TDeck Brightness Works in TFT Builds * Remove HAS_TFT from enabling Brightness, disable Brightness for TDeck * Add default textMessage frame actions and adjust SharedUIDisplay --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 22, 2025
…nements (meshtastic#7344) * Clock updates and some TDeck corrections * TDeck Brightness Works in TFT Builds * Remove HAS_TFT from enabling Brightness, disable Brightness for TDeck * Add default textMessage frame actions and adjust SharedUIDisplay --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 23, 2025
…nements (meshtastic#7344) * Clock updates and some TDeck corrections * TDeck Brightness Works in TFT Builds * Remove HAS_TFT from enabling Brightness, disable Brightness for TDeck * Add default textMessage frame actions and adjust SharedUIDisplay --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
…nements (meshtastic#7344) * Clock updates and some TDeck corrections * TDeck Brightness Works in TFT Builds * Remove HAS_TFT from enabling Brightness, disable Brightness for TDeck * Add default textMessage frame actions and adjust SharedUIDisplay --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.