Skip to content

Lib Update#6510

Merged
thebentern merged 6 commits into
masterfrom
nimble-2x
Apr 17, 2025
Merged

Lib Update#6510
thebentern merged 6 commits into
masterfrom
nimble-2x

Conversation

@caveman99

@caveman99 caveman99 commented Apr 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Draft because PIN display doesn't work yet.

@vidplace7 vidplace7 mentioned this pull request Apr 9, 2025
Closed
1 task
@caveman99 caveman99 mentioned this pull request Apr 11, 2025
Open
@alexbegoon alexbegoon mentioned this pull request Apr 13, 2025
Merged
@caveman99

caveman99 commented Apr 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

@alexbegoon the fix works, thanks a lot! :-) waiting for Ci to complete, then merging and folding back into the C6 PR. This can go in next :-)

@caveman99 caveman99 marked this pull request as ready for review April 17, 2025 20:29
Copilot AI reviewed Apr 17, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • arch/esp32/esp32.ini: Language not supported

@thebentern thebentern merged commit e2f6600 into master Apr 17, 2025
@thebentern thebentern deleted the nimble-2x branch April 17, 2025 20:58
@todd-herbert

todd-herbert commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Hey I think this is causing some weird results just now testing with Wireless Paper. From my Android 13 phone, the node can't be seen in either the Meshtastic app or the system Bluetooth settings.

The nRF Connect app does show the node, and allows me to bond with it. After bonding this way, the Meshtastic Android app works as normal.

Data from nRF Connect app

Screenshot_20250418_231410_nRF Connect

Screenshot_20250418_231402_nRF Connect

thebentern added a commit that referenced this pull request Apr 20, 2025
@thebentern
Revert "Lib Update (#6510)"
e027406 
This reverts commit e2f6600.
@thebentern thebentern mentioned this pull request Apr 20, 2025
Merged
thebentern added a commit that referenced this pull request Apr 20, 2025
@thebentern
Revert "Lib Update (#6510)" (#6640)
48dc0e0 
This reverts commit e2f6600.
cpatulea added a commit to cpatulea/firmware that referenced this pull request Feb 24, 2026
@cpatulea
Update all esp32 to NimBLE-Arduino v2.x (2.3.7).
a1578b4 
This has a few benefits:
- NimBLE-Arduino v1.x does not build under pioarduino (error: 'esp_timer_handle_t' does not name a type) so this creates more options for BLE stack in pioarduino migration (meshtastic#9122)
- This aligns all esp32 with esp32c6, which already uses NimBLE-Arduino 2.3.7.
- This allows setting NIMBLE_TWO on always and deleting all NimbleBluetooth.cpp code outside of ifdef NIMBLE_TWO.

This is a retry of meshtastic#6510.

Tested: Heltec v3 with iPhone
@cpatulea

cpatulea commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

FYI I tried again to make this update.

NIMBLE_TWO made this easier, though it still required a few code tweaks, it was not too bad: a1578b4

Testing:

  • Heltec v3: built and tested on real device + iPhone
  • All devices based on ESP32 original (8 out of 57 ESP32 devices): does not build. It increases the static RAM usage so much, the firmware can't link (/home/eigma/.platformio/packages/toolchain-xtensa-esp32/bin/../lib/gcc/xtensa-esp32-elf/8.4.0/../../../../xtensa-esp32-elf/bin/ld: .pio/build/m5stack-coreink/firmware-m5stack-coreink-2.7.20.a1578b4.elf section .dram0.bss will not fit in region dram0_0_seg). I spent a while trying to solve this but it seems really difficult and I don't have experience with shrinking static RAM usage.
  • All other devices (48 devices): confirmed it builds successfully but not tested.

I was doing this to find a way to help pioarduino migration move forward. I chatted with @phaseloop on Discord and he said we should instead invest efforts into pioarduino + Arduino-BLE (i.e. not NimBLE-Arduino). That work is ongoing here: #9132

so I won't be pursuing NimBLE-Arduino v2.x but I wanted to post my notes for posterity.

jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
@caveman99 @thebentern @alexbegoon
Lib Update (meshtastic#6510)
6b2d244 
* Lib Update

Draft because PIN display doesn't work yet.

* pin entry still no worky

* Fix for missing PIN code issue (meshtastic#6574)

---------

Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: Alexander Begoon <alex@begoonlab.tech>
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
@thebentern
Revert "Lib Update (meshtastic#6510)" (meshtastic#6640)
cb69e9c 
This reverts commit 6b2d244.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@thebentern thebentern thebentern approved these changes
@vidplace7 vidplace7 Awaiting requested review from vidplace7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@caveman99 @todd-herbert @cpatulea @thebentern @alexbegoon