Improve PKC unit test coverage#6485
Merged
Merged
Conversation
thebentern
approved these changes
Apr 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves unit test coverage for Curve25519-based PKC operations by adding tests for both encryption and decryption, ensuring that changes in behavior are tracked.
- Renamed the test function from test_PKC_Decrypt to test_PKC and expanded it to cover encryption.
- Introduced a new variable (packetNum) for clearer test parameters and added assertions to validate encryption and subsequent decryption.
Comments suppressed due to low confidence (1)
test/test_crypto/test_main.cpp:113
- [nitpick] The function name 'test_PKC' is generic; consider renaming it (e.g., 'test_Curve25519Crypto') to clearly indicate that it tests both encryption and decryption.
void test_PKC(void)
jp-bennett
approved these changes
Apr 3, 2025
8 tasks
jeek
pushed a commit
to jeek/Meshtastic-Exploiteers-Hacker-Pager
that referenced
this pull request
Jun 30, 2026
* Cleanup PKC unit test a bit * Add unit test coverage for encryptCurve25519 --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no unit test coverage for encryptCurve25519. As part of the efforts towards #6426, I want to make sure this behavior does not change.
🤝 Attestations
Tests pass natively:
pio test -e coverage