Skip to content

udp-multicast: do not listen for incoming udp multicast packets if disabled#6397

Merged
fifieldt merged 1 commit into
meshtastic:masterfrom
Jorropo:multicast/dont-listen-if-disabled
Mar 26, 2025
Merged

udp-multicast: do not listen for incoming udp multicast packets if disabled#6397
fifieldt merged 1 commit into
meshtastic:masterfrom
Jorropo:multicast/dont-listen-if-disabled

Conversation

@Jorropo

@Jorropo Jorropo commented Mar 26, 2025

Copy link
Copy Markdown
Member

Currently the config flag only control if packets are sent, not received.

As we discussed in VC this is not what was intended.

…sabled

Currently the config flag only control if packets are sent, not received.

As we discussed in VC this is not what was intended.
@fifieldt fifieldt merged commit 6429eca into meshtastic:master Mar 26, 2025
@Jorropo Jorropo deleted the multicast/dont-listen-if-disabled branch March 26, 2025 07:12
Jorropo added a commit to Jorropo/firmware that referenced this pull request Apr 29, 2025
This reverts commit ef18a9b.

Fixes meshtastic#6683, I have not tried to understand *why* this work, this was found by `git bisect`:
```
git bisect start
# status: waiting for both good and bad commits
# bad: [b4e8f7d] Update Adafruit BusIO digest to 159f86a (meshtastic#6681)
git bisect bad b4e8f7d
# status: waiting for good commit(s), bad commit known
# good: [6429eca] udp-multicast: do not listen for incoming udp multicast packets if disabled (meshtastic#6397)
git bisect good 6429eca
# bad: [1b1d462] chore: update ubx.h (meshtastic#6522)
git bisect bad 1b1d462
# good: [89cde1a] udp-multicast: bump platform-native to UDP with error handling support (meshtastic#6433)
git bisect good 89cde1a
# good: [2c01fad] meshtasticd: Add FrequencyLabs MeshAdv-Mini Hat (meshtastic#6458)
git bisect good 2c01fad
# bad: [0110275] Revert "Try-fix ESP32 wifi disconnects (meshtastic#6363)" (meshtastic#6493)
git bisect bad 0110275
# bad: [ef18a9b] meshtasticd: Set available.d dir in yaml (meshtastic#6481)
git bisect bad ef18a9b
# good: [ea4ce8d] MUI unPhone-tft: fix defaults (meshtastic#6477)
git bisect good ea4ce8d
# good: [f6ed10f] Added initial support for Texas Instruments LP5562 (meshtastic#6381)
git bisect good f6ed10f
# good: [67fddcc] Upgrade trunk (meshtastic#6480)
git bisect good 67fddcc
# first bad commit: [ef18a9b] meshtasticd: Set available.d dir in yaml (meshtastic#6481)
```
I have tested this patch and it does work as expected after reverting.
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
…sabled (meshtastic#6397)

Currently the config flag only control if packets are sent, not received.

As we discussed in VC this is not what was intended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants