Skip to content

Finish powermon/powerstress#4230

Merged
thebentern merged 74 commits into
meshtastic:masterfrom
geeksville:pr-powermon2
Aug 6, 2024
Merged

Finish powermon/powerstress#4230
thebentern merged 74 commits into
meshtastic:masterfrom
geeksville:pr-powermon2

Conversation

@geeksville

@geeksville geeksville commented Jul 4, 2024

Copy link
Copy Markdown
Member

This is the final changes for the powermon/powerstress stuff. Sorry for the long list of CLs, but I have been merging from master for a while so hard to rebase/collapse the various non merge changes into a single CL.

There are three main changes:

  • Implement the PowerStress class so that the python code can ask the unit under test (UUT) to transition through various modes while it measures the power consumed by the board. (This class is not used in normal operation)
  • Have various places that are doing power changing things (turning on power rails, changing radio modes etc...) call hooks on the powermon singleton to indicate those operations are happening. Those hooks emit a structured string to the log file output. This class is tiny so I left it on by default.
  • Add GpioTransformer/GpioPin classes which I will soon use for decreasing Heltec tracker power consumption (by managing the dedicated screen+gps power regulator more conservatively). Currently this class is only used for the power led (so that the led can be controlled by PowerStress - and then we eventually calibrate/detect from the python side that the bench power measurement is working).

Any feedback/comments would be appreciated! (sorry for the delay - I took an extra week off from programming but now back at it)

For #4136

Initial platformio.ini file only supports rak4630
Default to non TCP for the semihosting log output for now...
Fixes meshtastic#4135
By disabling the (inaccessible) adafruit USB
Not yet used but I didn't want these nasty tricks to get lost yet.
without this flag if the user has set some other formatter (clang)
in their user level settings, it will be looking in the wrong directory
for the clang options (we want the options in .trunk/clang)

Note: formatOnSave is true in master, which means a bunch of our older
files are non compliant and if you edit them it will generate lots of
formatting related diffs.  I guess I'll start letting that happen with
my future commits ;-).
@geeksville geeksville marked this pull request as ready for review July 31, 2024 19:04
@geeksville geeksville marked this pull request as draft July 31, 2024 19:07
@geeksville geeksville marked this pull request as ready for review July 31, 2024 19:14
@thebentern thebentern requested a review from todd-herbert August 3, 2024 13:26

@todd-herbert todd-herbert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing looked odd to me, but when I built and ran this for T-Beam V1.2 it crashes at boot.
(Update: same for DIY V1)

0x40152b0f: do_global_ctors at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp_system/startup.c:201
0x40152b0f: start_cpu0_default at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp_system/startup.c:449
0x40083aad: call_start_cpu0 at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp_system/port/cpu_start.c:687

Not sure if it's this PR or something unrelated from master. Will keep building stuff here and see if anything turns up.


Update: Heltec Wireless Paper (ESP32-S3) also crashing on boot:

#0  0x42003848 in _ZN8PowerMon8setStateE26_meshtastic_PowerMon_StatePKc$constprop$944 at ??:?
  #1  0x42065345 in MonitoredLedPin::set(bool) at ??:?
  #2  0x420652e2 in GpioBinaryTransformer::update() at ??:?
  #3  0x42009b9a in global constructors keyed to 65535_0_BluetoothCommon_cpp_o$235855 at :?
  #4  0x42076096 in do_global_ctors at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp_system/startup.c:201
      (inlined by) start_cpu0_default at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp_system/startup.c:449
  #5  0x4037744f in call_start_cpu0 at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp_system/port/cpu_start.c:687

Update 2: master seems to still be running fine

@geeksville

Copy link
Copy Markdown
Member Author

@todd-herbert your note prompted me to try it on a tbeam! You are correct. I'll take a look!

@geeksville geeksville marked this pull request as draft August 4, 2024 15:49
Thanks @todd-herbert for noticing this and the great stack trace.
The root cause was that I had accidentially shadowed outPin in a subclass
with an unneeded override.  It would break on any board that had inverted
LED power.

fixes
meshtastic#4230 (review)
While investigating meshtastic#4230 (review)
I noticed in variant.h that there are now apparently newer TBEAMs than mine
that have _both_ a GPIO based power LED and the PMU based LED.  Add a splitter
so that we can drive two output GPIOs from one logical signal.
@geeksville geeksville marked this pull request as ready for review August 4, 2024 19:04
@geeksville

Copy link
Copy Markdown
Member Author

thanks @todd-herbert - I think ready to go (again ;-) )

@todd-herbert todd-herbert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you got it! All running as normal here 👍

@geeksville

geeksville commented Aug 6, 2024

Copy link
Copy Markdown
Member Author

thanks @todd-herbert. Updated wrt master (and retested on tbeam and rak4631) and I think ready to merge. cool @thebentern? (I'm lazy and eager to not keep updating wrt master. heh)

@thebentern

Copy link
Copy Markdown
Contributor

Sounds good. Merging :D

@thebentern thebentern merged commit c1870f9 into meshtastic:master Aug 6, 2024
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
* Turn off vscode cmake prompt - we don't use cmake on meshtastic

* Add rak4631_dap variant for debugging with NanoDAP debug probe device.

* The rak device can also run freertos (which is underneath nrf52 arduino)

* Add semihosting support for nrf52840 devices
Initial platformio.ini file only supports rak4630
Default to non TCP for the semihosting log output for now...
Fixes meshtastic#4135

* powermon WIP (for meshtastic#4136 )

* oops - mean't to mark the _dbg variant as an 'extra' board.

* powermon wip

* Make serial port on wio-sdk-wm1110 board work
By disabling the (inaccessible) adafruit USB

* Instrument (radiolib only for now) lora for powermon
per meshtastic#4136

* powermon gps support
meshtastic#4136

* Add CPU deep and light sleep powermon states
meshtastic#4136

* Change the board/swversion bootstring so it is a new "structured" log msg.

* powermon wip

* add example script for getting esp S3 debugging working
Not yet used but I didn't want these nasty tricks to get lost yet.

* Add PowerMon reporting for screen and bluetooth pwr.

* make power.powermon_enables config setting work.

* update to latest protobufs

* fix bogus shellcheck warning

* make powermon optional (but default enabled because tiny and no runtime impact)

* tell vscode, if formatting, use whatever our trunk formatter wants
without this flag if the user has set some other formatter (clang)
in their user level settings, it will be looking in the wrong directory
for the clang options (we want the options in .trunk/clang)

Note: formatOnSave is true in master, which means a bunch of our older
files are non compliant and if you edit them it will generate lots of
formatting related diffs.  I guess I'll start letting that happen with
my future commits ;-).

* add PowerStress module

* nrf52 arduino is built upon freertos, so let platformio debug it

* don't accidentally try to Segger ICE if we are using another ICE

* clean up RedirectablePrint::log so it doesn't have three very different implementations inline.

* remove NoopPrint - it is no longer needed

* when talking to API clients via serial, don't turn off log msgs instead encapsuate them

* fix the build - would loop forever if there were no files to send

* don't use Segger code if not talking to a Segger debugger

* when encapsulating logs, make sure the strings always has nul terminators

* nrf52 soft device will watchdog if you use ICE while BT on...
so have debugger disable bluetooth.

* Important to not print debug messages while writing to the toPhone scratch buffer

* don't include newlines if encapsulating log records as protobufs

* update to latest protobufs (needed for powermon goo)

* PowerStress WIP

* for meshtastic#4154 and meshtastic#4136 add concept of dependent gpios...
Which is currently only tested with the LED but eventually
will be used for shared GPIO/screen power rail enable
and LED forcing (which is a sanity check in the power stress
testing)

* fix linter warning

* Transformer is a better name for the LED input > operation > output classes

* PMW led changes to work on esp32-s3

* power stress improvements

* allow ble logrecords to be fetched either by NOTIFY or INDICATE ble types

This allows 'lossless' log reading.  If client has requested INDICATE
(rather than NOTIFY) each log record emitted via log() will have to fetched
by the client device before the meshtastic node can continue.

* Fix serious problem with nrf52 BLE logging.
When doing notifies of LogRecords it is important to use the
binary write routines - writing using the 'string' write won't work.
Because protobufs can contain \0 nuls inside of them which if being
parsed as a string will cause only a portion of the protobuf to be sent.
I noticed this because some log messages were not getting through.

* fix gpio transformer stuff to work correctly with LED_INVERTED

Thanks @todd-herbert for noticing this and the great stack trace.
The root cause was that I had accidentially shadowed outPin in a subclass
with an unneeded override.  It would break on any board that had inverted
LED power.

fixes
meshtastic#4230 (review)

* Support driving multiple output gpios from one input.

While investigating meshtastic#4230 (review)
I noticed in variant.h that there are now apparently newer TBEAMs than mine
that have _both_ a GPIO based power LED and the PMU based LED.  Add a splitter
so that we can drive two output GPIOs from one logical signal.

---------

Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants