Be smarter about heltec power rail shared btw GPS and screen (for #4154)#4211
Closed
geeksville wants to merge 5 commits into
Closed
Be smarter about heltec power rail shared btw GPS and screen (for #4154)#4211geeksville wants to merge 5 commits into
geeksville wants to merge 5 commits into
Conversation
…s... Which is currently only tested with the LED but eventually will be used for shared GPIO/screen power rail enable and LED forcing (which is a sanity check in the power stress testing)
todd-herbert
approved these changes
Jul 4, 2024
todd-herbert
left a comment
Contributor
There was a problem hiding this comment.
Calls like ledBlink.set(bool) seem really tidy! What it's doing under-the-hood is definitely making my brain melt a little, but that's a "my brain" comment, not a code comment!
Member
Author
|
Hi @todd-herbert I just merged in the latest master. Look okay to merge? (if these CI builds succeed ;-)) |
22a43bf to
69d8446
Compare
Member
Author
|
already included in the later PR #4230 that builds upon this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will be used for power stress testing (for the LED current draw sanity test/board autocalibration) but it is mainly to (eventually) improve heltec tracker power consumption.
In the common case it should be almost 100% inlined.