Skip to content

Turn off certain modules not wanted in custom builds#3337

Merged
thebentern merged 1 commit into
masterfrom
module-off
Mar 5, 2024
Merged

Turn off certain modules not wanted in custom builds#3337
thebentern merged 1 commit into
masterfrom
module-off

Conversation

@caveman99

Copy link
Copy Markdown
Member

No description provided.

@thebentern

Copy link
Copy Markdown
Contributor

Good idear! Very Radiolib-esque. Would it make sense to eventually use these in the different architecture base platformio build flags to control the module injections there instead of directly in the modules with the arch macros?

@thebentern thebentern merged commit f5ff77c into master Mar 5, 2024
@caveman99

caveman99 commented Mar 5, 2024

Copy link
Copy Markdown
Member Author

Turns out i forgot the inputbroker in the 'nuke all' macro... will revisit tomorrow. It's not a real saving, gives you 2% flash on a t-beam.

I'd like to keep both options available, arch and module macros. this way the tuning is more granular, and you can make 'feature firmwares' for memory restraint devices. Apollo-Router, Apollo-Tracker, Apollo-Sensor and so on.

Also i'd like to propose this as a kind of standard to exclude functionality from builds, even outside the modules. Implementation may be a bit more complicated for other things though. Xmodem comes to mind, or an ESP32 build without webserver (hint, hint)

@jimwhitelaw

Copy link
Copy Markdown
Contributor

or an ESP32 build without webserver (hint, hint)

I've done most of the work for this in my project already and would be happy to contribute it. Question: with no webserver, is there still a use case for enabling wifi? My code currently assumes there is not and disables both.

@jp-bennett

Copy link
Copy Markdown
Collaborator

with no webserver, is there still a use case for enabling wifi?

Technically there is still the TCP API, usable through the CLI and a couple apps.

@jimwhitelaw

Copy link
Copy Markdown
Contributor

OK, thx. My initial work started with disabling wifi and then anything that depended on that, but now that I know it makes sense to have the TCP/wifi and webserver independently enabled, I can re-write to support that.

@garthvh

garthvh commented Mar 10, 2024

Copy link
Copy Markdown
Member

This is likely to crash when connected to a client app.

@jimwhitelaw

Copy link
Copy Markdown
Contributor

 @garthvh Can you elaborate? I've been testing and haven't found any crash scenario, just that CLI and web apps fail to connect when webserver is disabled. BT connection with iOS app still works fine.

@mverch67 mverch67 mentioned this pull request Jul 5, 2024
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants