Skip to content

Set config.lora.hop_limit to HOP_RELIABLE#1656

Merged
sachaw merged 7 commits into
masterfrom
pref_defaults
Sep 10, 2022
Merged

Set config.lora.hop_limit to HOP_RELIABLE#1656
sachaw merged 7 commits into
masterfrom
pref_defaults

Conversation

@sachaw

@sachaw sachaw commented Aug 27, 2022

Copy link
Copy Markdown
Member

Thank you for sending in a pull request, here's some tips to get started!

(Please delete all these tips and replace with your text)

  • Before starting on some new big chunk of code, it it is optional but highly recommended to open an issue first
    to say "hey, I think this idea X should be implemented and I'm starting work on it. My general plan is Y, any feedback
    is appreciated." This will allow other devs to potentially save you time by not accidentially duplicating work etc...
  • Please do not check in files that don't have real changes
  • Please do not reformat lines that you didn't have to change the code on
  • We recommend using the Visual Studio Code editor and the 'clang-format' extension,
    because automatically follows our indentation rules and it's auto reformatting will not cause spurious changes to lines.
  • If your PR fixes a bug, mention "fixes #bugnum" somewhere in your pull request description.
  • If your other co-developers have comments on your PR please tweak as needed.

@sachaw sachaw marked this pull request as draft August 27, 2022 09:04
@github-actions

github-actions Bot commented Aug 27, 2022

Copy link
Copy Markdown
Contributor

🤖 Pull request artifacts

file commit
pr1656-firmware-1.3.41.7aaca3d.zip 7aaca3d

thebentern added a commit to meshtastic/artifacts that referenced this pull request Aug 27, 2022
@garthvh

garthvh commented Aug 28, 2022

Copy link
Copy Markdown
Member

@thebentern and I talked about this new structure and it seems like a good plan, I would like @andrekir to weigh in as he has the largest app user base and the most legacy code to manage currently.

@andrekir

Copy link
Copy Markdown
Contributor

don't expect any issues going ahead with this change. do we have a list of defaults to add?

@sachaw

sachaw commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

There won't be any defaults that you need to define in the apps, only remove them if you have any.
I'll update this pr with the rest of them.
End goal being that the device reports it's entire state without needing to make any assumptions

thebentern added a commit to meshtastic/artifacts that referenced this pull request Aug 30, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Aug 30, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Sep 3, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Sep 4, 2022
@garthvh

garthvh commented Sep 7, 2022

Copy link
Copy Markdown
Member

I like it

thebentern added a commit to meshtastic/artifacts that referenced this pull request Sep 7, 2022
@sachaw

sachaw commented Sep 10, 2022

Copy link
Copy Markdown
Member Author

I'm going to merge this, we can convert the others later

@sachaw sachaw marked this pull request as ready for review September 10, 2022 08:10
thebentern added a commit to meshtastic/artifacts that referenced this pull request Sep 10, 2022
@sachaw sachaw merged commit 0167304 into master Sep 10, 2022
@sachaw sachaw deleted the pref_defaults branch September 10, 2022 08:24
jeek pushed a commit to jeek/Meshtastic-Exploiteers-Hacker-Pager that referenced this pull request Jun 30, 2026
Set `config.lora.hop_limit` to `HOP_RELIABLE`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants